feat(storage): name from metadata for nft token in tokens table

Author: Larkooo

crates/sqlite/sqlite/src/executor/erc.rs

@@ -44,6 +44,20 @@ pub struct TokenTrait {
     pub trait_value: String,
 }
 
+/// Extract the name from NFT metadata JSON if present
+pub fn extract_name_from_metadata(metadata: &str) -> Option<String> {
+    if metadata.is_empty() {
+        return None;
+    }
+
+    let metadata_json: serde_json::Value = serde_json::from_str(metadata).ok()?;
+    metadata_json
+        .get("name")
+        .and_then(|v| v.as_str())
+        .map(|s| s.to_string())
+        .filter(|s| !s.is_empty())
+}
+
 /// Extract traits from NFT metadata JSON
 pub fn extract_traits_from_json(metadata: &str) -> Result<Vec<TokenTrait>, serde_json::Error> {
     let metadata_json: serde_json::Value = serde_json::from_str(metadata)?;
@@ -473,6 +487,34 @@ mod tests {
     use super::*;
     use serde_json::json;
 
+    #[test]
+    fn test_extract_name_from_metadata() {
+        // Test with valid name
+        let metadata = r#"{"name": "Cool NFT #42", "description": "A cool NFT"}"#;
+        assert_eq!(
+            extract_name_from_metadata(metadata),
+            Some("Cool NFT #42".to_string())
+        );
+
+        // Test with empty name
+        let metadata = r#"{"name": "", "description": "A cool NFT"}"#;
+        assert_eq!(extract_name_from_metadata(metadata), None);
+
+        // Test with no name field
+        let metadata = r#"{"description": "A cool NFT"}"#;
+        assert_eq!(extract_name_from_metadata(metadata), None);
+
+        // Test with empty metadata
+        assert_eq!(extract_name_from_metadata(""), None);
+
+        // Test with invalid JSON
+        assert_eq!(extract_name_from_metadata("invalid json"), None);
+
+        // Test with name as number (should return None)
+        let metadata = r#"{"name": 123}"#;
+        assert_eq!(extract_name_from_metadata(metadata), None);
+    }
+
     #[test]
     fn test_extract_traits_from_json() {
         let metadata = r#"{

crates/sqlite/sqlite/src/executor/mod.rs

@@ -6,7 +6,7 @@ use std::time::{SystemTime, UNIX_EPOCH};
 use cainome::cairo_serde::{ByteArray, CairoSerde};
 use dojo_types::schema::{Struct, Ty};
 use erc::{
-    store_token_attributes, update_contract_traits_from_metadata,
+    extract_name_from_metadata, store_token_attributes, update_contract_traits_from_metadata,
     update_contract_traits_on_metadata_change, UpdateTokenMetadataQuery,
 };
 use metrics::{counter, histogram};
@@ -969,7 +969,7 @@ impl<P: Provider + Sync + Send + Clone + 'static> Executor<'_, P> {
 
                 // If we find a token already registered for this contract_address we dont need to
                 // refetch the data since its same for all tokens of this contract
-                let (name, symbol) = match res {
+                let (contract_name, symbol) = match res {
                     Ok((name, symbol)) => {
                         debug!(
                             target: LOG_TARGET,
@@ -1058,6 +1058,10 @@ impl<P: Provider + Sync + Send + Clone + 'static> Executor<'_, P> {
                     }
                 };
 
+                // Try to get name from token metadata, fallback to contract name
+                let name = extract_name_from_metadata(&register_nft_token.metadata)
+                    .unwrap_or(contract_name);
+
                 let query = sqlx::query_as::<_, torii_sqlite_types::Token>(
                     "INSERT INTO tokens (id, contract_address, token_id, name, symbol, decimals, \
                      metadata, total_supply, traits) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?) RETURNING *",