Merge pull request dokuwiki#4307 from fiwswe/nit-AbstractAction

splitbrain · web-flow · commit 0aef97587d88 · 2024-10-30T19:17:38.000+01:00
Very minor performance nit in AbstractAction constructor
diff --git a/inc/Action/AbstractAction.php b/inc/Action/AbstractAction.php
@@ -27,8 +27,8 @@ public function __construct($actionname = '')
         if ($actionname !== '') {
             $this->actionname = $actionname;
         } else {
-            // http://stackoverflow.com/a/27457689/172068
-            $this->actionname = strtolower(substr(strrchr(get_class($this), '\\'), 1));
+            // As of PHP 8 this seems to be the fastest way to get the name:
+            $this->actionname = strtolower((new \ReflectionClass($this))->getShortName());
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,8 @@ public function __construct($actionname = '')`
`27`	`27`	`if ($actionname !== '') {`
`28`	`28`	`$this->actionname = $actionname;`
`29`	`29`	`} else {`
`30`		`- // http://stackoverflow.com/a/27457689/172068`
`31`		`- $this->actionname = strtolower(substr(strrchr(get_class($this), '\\'), 1));`
	`30`	`+ // As of PHP 8 this seems to be the fastest way to get the name:`
	`31`	`+ $this->actionname = strtolower((new \ReflectionClass($this))->getShortName());`
`32`	`32`	`}`
`33`	`33`	`}`
`34`	`34`