Merge pull request dokuwiki#4414 from dokuwiki/fixapierrorcode

do not return zero error code for API exceptions. fixes dokuwiki#4413

Author: splitbrain

inc/Remote/JsonRpcServer.php

@@ -143,7 +143,7 @@ protected function addErrorData(&$response, $e = null)
         if ($e !== null) {
             // error occured, add to response
             $response['error'] = [
-                'code' => $e->getCode(),
+                'code' => $e->getCode() ?: 1, // 0 is success, so we use 1 as default
                 'message' => $e->getMessage()
             ];
         } else {

lib/exe/xmlrpc.php

@@ -15,5 +15,5 @@
 try {
     $server->serve();
 } catch (\Exception $e) {
-    $server->error($e->getCode(), $e->getMessage());
+    $server->error($e->getCode() ?: 1, $e->getMessage());
 }