fix revisions used in RSS feeds. fixes dokuwiki#4357

splitbrain · splitbrain · commit 389c05a6bc94 · 2024-11-27T09:41:04.000+01:00
A negative value needs to be passed to retrieve the current revision.
diff --git a/inc/Feed/FeedMediaProcessor.php b/inc/Feed/FeedMediaProcessor.php
@@ -139,7 +139,7 @@ public function isExisting()
     protected function loadRevisions()
     {
         $changelog = new MediaChangeLog($this->id);
-        $revs = $changelog->getRevisions(0, 2);  // FIXME check that this returns the current one correctly
+        $revs = $changelog->getRevisions(-1, 2);
         if (!isset($this->data['rev'])) {
             // prefer an already set date, only set if missing
             // it should usally not happen that neither is available
diff --git a/inc/Feed/FeedPageProcessor.php b/inc/Feed/FeedPageProcessor.php
@@ -185,7 +185,7 @@ protected function getMetaData()
     protected function loadRevisions()
     {
         $changelog = new PageChangeLog($this->id);
-        $revs = $changelog->getRevisions(0, 2); // FIXME check that this returns the current one correctly
+        $revs = $changelog->getRevisions(-1, 2);
         if (!isset($this->data['rev'])) {
             // prefer an already set date, only set if missing
             // it should usally not happen that neither is available

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ public function isExisting()`
`139`	`139`	`protected function loadRevisions()`
`140`	`140`	`{`
`141`	`141`	`$changelog = new MediaChangeLog($this->id);`
`142`		`- $revs = $changelog->getRevisions(0, 2); // FIXME check that this returns the current one correctly`
	`142`	`+ $revs = $changelog->getRevisions(-1, 2);`
`143`	`143`	`if (!isset($this->data['rev'])) {`
`144`	`144`	`// prefer an already set date, only set if missing`
`145`	`145`	`// it should usally not happen that neither is available`
Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ protected function getMetaData()`
`185`	`185`	`protected function loadRevisions()`
`186`	`186`	`{`
`187`	`187`	`$changelog = new PageChangeLog($this->id);`
`188`		`- $revs = $changelog->getRevisions(0, 2); // FIXME check that this returns the current one correctly`
	`188`	`+ $revs = $changelog->getRevisions(-1, 2);`
`189`	`189`	`if (!isset($this->data['rev'])) {`
`190`	`190`	`// prefer an already set date, only set if missing`
`191`	`191`	`// it should usally not happen that neither is available`