Extension Manager: show updatemessage for installed extensions only

splitbrain · splitbrain · commit d98308b7421d · 2024-12-04T15:15:39.000+01:00
diff --git a/lib/plugins/extension/Notice.php b/lib/plugins/extension/Notice.php
@@ -163,7 +163,8 @@ protected function checkPHPVersion()
      */
     protected function checkUpdateMessage()
     {
-        // FIXME should we only display this for installed extensions?
+        // only display this for installed extensions
+        if (!$this->extension->isInstalled()) return;
         if ($msg = $this->extension->getUpdateMessage()) {
             $this->notices[self::WARNING][] = sprintf($this->getLang('update_message'), $msg);
         }

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,8 @@ protected function checkPHPVersion()`
`163`	`163`	`*/`
`164`	`164`	`protected function checkUpdateMessage()`
`165`	`165`	`{`
`166`		`- // FIXME should we only display this for installed extensions?`
	`166`	`+ // only display this for installed extensions`
	`167`	`+ if (!$this->extension->isInstalled()) return;`
`167`	`168`	`if ($msg = $this->extension->getUpdateMessage()) {`
`168`	`169`	`$this->notices[self::WARNING][] = sprintf($this->getLang('update_message'), $msg);`
`169`	`170`	`}`