Fix reference assignment of plugin_load

Author: michitux

action.php

@@ -301,9 +301,9 @@ function handle_secedit_button(Doku_Event &$event, $params) {
             // Special handling for the edittable plugin
             if ($data['target'] == 'table' && !plugin_isdisabled('edittable')) {
                 /* @var action_plugin_edittable_editor $edittable */
-                $edittable =& plugin_load('action', 'edittable_editor');
+                $edittable = plugin_load('action', 'edittable_editor');
                 if (is_null($edittable))
-                    $edittable =& plugin_load('action', 'edittable');
+                    $edittable = plugin_load('action', 'edittable');
                 $data['name'] = $edittable->getLang('secedit_name');
             }
 

helper.php

@@ -711,7 +711,7 @@ function _get_included_pages($mode, $page, $sect, $parent_id, $flags) {
             break;
         case 'tagtopic':
             if (!$this->taghelper)
-                $this->taghelper =& plugin_load('helper', 'tag');
+                $this->taghelper = plugin_load('helper', 'tag');
             if(!$this->taghelper) {
                 msg('You have to install the tag plugin to use this functionality!', -1);
                 return array();

syntax/footer.php

@@ -101,21 +101,21 @@ function html_footer($page, $sect, $sect_title, $flags, $footer_lvl, &$renderer)
         }
 
         // comments - let Discussion Plugin do the work for us
-        if (empty($sect) && $flags['comments'] && (!plugin_isdisabled('discussion')) && ($discussion =& plugin_load('helper', 'discussion'))) {
+        if (empty($sect) && $flags['comments'] && (!plugin_isdisabled('discussion')) && ($discussion = plugin_load('helper', 'discussion'))) {
             $disc = $discussion->td($page);
             if ($disc) $xhtml[] = '<span class="comment">' . $disc . '</span>';
         }
 
         // linkbacks - let Linkback Plugin do the work for us
-        if (empty($sect) && $flags['linkbacks'] && (!plugin_isdisabled('linkback')) && ($linkback =& plugin_load('helper', 'linkback'))) {
+        if (empty($sect) && $flags['linkbacks'] && (!plugin_isdisabled('linkback')) && ($linkback = plugin_load('helper', 'linkback'))) {
             $link = $linkback->td($page);
             if ($link) $xhtml[] = '<span class="linkback">' . $link . '</span>';
         }
 
         $xhtml = implode(DOKU_LF . DOKU_TAB . '&middot; ', $xhtml);
 
         // tags - let Tag Plugin do the work for us
-        if (empty($sect) && $flags['tags'] && (!plugin_isdisabled('tag')) && ($tag =& plugin_load('helper', 'tag'))) {
+        if (empty($sect) && $flags['tags'] && (!plugin_isdisabled('tag')) && ($tag = plugin_load('helper', 'tag'))) {
             $tags = $tag->td($page);
             if($tags) {
                 $xhtml .= '<div class="tags"><span>' . DOKU_LF

syntax/header.php

@@ -76,7 +76,7 @@ function render($mode, Doku_Renderer $renderer, $data) {
      * @author Michael Klier <[email protected]>
      */
     function _get_firsttag($page) {
-        if(plugin_isdisabled('tag') || (!$taghelper =& plugin_load('helper', 'tag'))) {
+        if(plugin_isdisabled('tag') || (!plugin_load('helper', 'tag'))) {
             return false;
         }
         $subject = p_get_metadata($page, 'subject');