Skip to content

Commit 7af529e

Browse files
committed
Remove arrow functions in favor of function expressions
1 parent c5d2c87 commit 7af529e

File tree

2 files changed

+25
-22
lines changed

2 files changed

+25
-22
lines changed

src/index.stories.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ import '@storybook/addon-console'
44
import '@storybook/addon-actions/register'
55
import { useLog } from '.'
66

7-
export const App = (): React.ReactElement => {
7+
export function App(): React.ReactElement {
88
const [isExampleMounted, setIsExampleMounted] = useState<boolean>(true)
99

10-
setTimeout(() => {
10+
setTimeout(function setIsMounted() {
1111
setIsExampleMounted(false)
1212
}, 3000)
1313

@@ -20,24 +20,24 @@ export const App = (): React.ReactElement => {
2020
)
2121
}
2222

23-
export const ExampleComponent = (): React.ReactElement => {
23+
export function ExampleComponent(): React.ReactElement {
2424
const { log } = useLog()
2525
const [state, setState] = useState<string | null>(null)
2626

2727
log(state)
2828

29-
useEffect(() => {
29+
useEffect(function setStateMount() {
3030
setState('onMount')
3131

32-
setTimeout(() => {
32+
setTimeout(function setStateChange1() {
3333
setState('onChange 1s')
3434
}, 1000)
3535

36-
setTimeout(() => {
36+
setTimeout(function setStateChange2() {
3737
setState('onChange 2s')
3838
}, 2000)
3939

40-
return () => {
40+
return function setStateUnmount() {
4141
setState('onUnmount')
4242
}
4343
}, [])

src/index.tsx

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export function useLog(): UseLogReturn {
4242
}
4343
})() ?? ''
4444

45-
const getGroupLabel = (type: PrintTypes): string => {
45+
function getGroupLabel(type: PrintTypes): string {
4646
return `${String(type)} ${
4747
componentName ? 'in %c<' + String(componentName) + ' /> ' : '%c'
4848
}%c@ ${new Date().toLocaleTimeString()}`
@@ -75,15 +75,15 @@ export function useLog(): UseLogReturn {
7575
const prevValueRef = useRef<T>()
7676

7777
if (ALLOWED_NODE_ENVS.includes(process.env.NODE_ENV ?? '')) {
78-
return (() => {
78+
return (function logHooks() {
7979
const isUnmounting = useRef(false)
80-
useEffect(() => {
81-
return () => {
80+
useEffect(function setIsUnmounting() {
81+
return function setIsUnmountingOnMount() {
8282
isUnmounting.current = true
8383
}
8484
}, [])
8585

86-
useEffect(() => {
86+
useEffect(function onMount() {
8787
print({
8888
label: 'On mount',
8989
value: clonedValue,
@@ -92,7 +92,7 @@ export function useLog(): UseLogReturn {
9292

9393
prevValueRef.current = value
9494

95-
return () => {
95+
return function onUnmount() {
9696
print({
9797
label: 'On unmount',
9898
value: clonedValue,
@@ -102,16 +102,19 @@ export function useLog(): UseLogReturn {
102102
}
103103
}, [])
104104

105-
useEffect(() => {
106-
print({
107-
label: 'On change',
108-
value: clonedValue,
109-
type: PrintTypes.Change,
110-
prevValue: prevValueRef.current,
111-
})
105+
useEffect(
106+
function onChange() {
107+
print({
108+
label: 'On change',
109+
value: clonedValue,
110+
type: PrintTypes.Change,
111+
prevValue: prevValueRef.current,
112+
})
112113

113-
prevValueRef.current = value
114-
}, [value])
114+
prevValueRef.current = value
115+
},
116+
[value],
117+
)
115118
})()
116119
}
117120
}

0 commit comments

Comments
 (0)