AJ-565: code review

Author: lucaijun

src/com/xxdb/SimpleDBConnectionPool.java

@@ -109,7 +109,7 @@ protected class SimpleDBConnectionPoolImpl {
                 if (userId.isEmpty() || password.isEmpty())
                     log.warn("Create connection pool successfully without log in.");
                 else
-                    log.info("Create connection pool successfully with log in.");
+                    log.info(String.format("Create connection pool successfully with user: %s log in.", userId));
             } catch (Exception e) {
                 log.error("Create connection pool failure, because " + e.getMessage());
                 throw new RuntimeException(e);
@@ -202,14 +202,14 @@ public void login(String userId, String password, boolean enableEncryption) thro
         @Override
         public void close() {
             if (isBusy())
-                log.error("Cannot release the connection,is running now.");
+                log.error("Cannot release the connection, is running now.");
             else {
                 try {
                     BasicInt ret = (BasicInt) run("1+1", true);
                     if (!ret.isNull() && (ret.getInt() == 2))
                         inUse.compareAndSet(true, false);
                     else
-                        log.error("Cannot release memory,release connection failure.");
+                        log.error("Cannot release memory, release connection failure.");
                 } catch (Exception e) {
                     log.error("Cannot release memory, because " + e.getMessage());
                 }

src/com/xxdb/SimpleDBConnectionPoolConfig.java

@@ -122,11 +122,11 @@ public void setHighAvailabilitySites(String[] highAvailabilitySites) {
         this.highAvailabilitySites = highAvailabilitySites;
     }
 
-    public void validate() {
+    protected void validate() {
         hostName = getNullIfEmpty(hostName);
         if (Objects.isNull(hostName)) {
             hostName = "localhost";
-            log.warn("HostName not set, use the default value 'localhost'");
+            log.warn("The param hostName not set, use the default value 'localhost'");
         }
         if (!checkHostNameValid(hostName))
             throw new RuntimeException(String.format("Invalid hostName: %s", hostName));
@@ -137,12 +137,12 @@ public void validate() {
         userId = getNullIfEmpty(userId);
         if (Objects.isNull(userId)){
             userId = "";
-            log.warn("Logging in needs userId.");
+            log.warn("Log in needs userId.");
         }
         password = getNullIfEmpty(password);
         if (Objects.isNull(password)){
             password = "";
-            log.warn("Logging in needs password.");
+            log.warn("Log in needs password.");
         }
         if (initialPoolSize <= 0) {
             initialPoolSize = 5;