Progress on schemas table

Author: tbantle22

go/cmd/dolt/commands/commit.go

@@ -713,7 +713,8 @@ func printStagedDiffs(wr io.Writer, stagedRows []sql.Row, printHelp bool) int {
 
 		lines := make([]string, 0, len(stagedRows))
 		for _, row := range stagedRows {
-			if !doltdb.IsReadOnlySystemTable(row[0].(string)) {
+			tblName := row[0].(string)
+			if !doltdb.IsReadOnlySystemTable(tblName, doltdb.HasDoltPrefix(tblName)) {
 				switch row[1].(string) {
 				case "new table":
 					lines = append(lines, fmt.Sprintf(statusFmt, tblDiffTypeToLabel[diff.AddedTable], row[0].(string)))

go/cmd/dolt/commands/diff.go

@@ -779,7 +779,8 @@ func diffUserTables(queryist cli.Queryist, sqlCtx *sql.Context, dArgs *diffArgs)
 
 	doltSchemasChanged := false
 	for _, delta := range deltas {
-		if doltdb.IsFullTextTable(delta.TableName.Name) {
+		tableName := delta.TableName.Name
+		if doltdb.IsFullTextTable(tableName, doltdb.HasDoltPrefix(tableName)) {
 			continue
 		}
 
@@ -851,7 +852,7 @@ func shouldPrintTableDelta(tablesToPrint *set.StrSet, toTableName, fromTableName
 }
 
 func isDoltSchemasTable(toTableName, fromTableName string) bool {
-	return fromTableName == doltdb.SchemasTableName || toTableName == doltdb.SchemasTableName
+	return fromTableName == doltdb.GetSchemasTableName() || toTableName == doltdb.GetSchemasTableName()
 }
 
 func getTableInfoAtRef(queryist cli.Queryist, sqlCtx *sql.Context, tableName string, ref string) (diff.TableInfo, error) {
@@ -1203,7 +1204,7 @@ func diffDoltSchemasTable(
 	query, err := dbr.InterpolateForDialect("select from_name,to_name,from_type,to_type,from_fragment,to_fragment "+
 		"from dolt_diff(?, ?, ?) "+
 		"order by coalesce(from_type, to_type), coalesce(from_name, to_name)",
-		[]interface{}{dArgs.fromRef, dArgs.toRef, doltdb.SchemasTableName}, dialect.MySQL)
+		[]interface{}{dArgs.fromRef, dArgs.toRef, doltdb.GetSchemasTableName()}, dialect.MySQL)
 	if err != nil {
 		return errhand.BuildDError("Error building diff query").AddCause(err).Build()
 	}

go/cmd/dolt/commands/dump.go

@@ -123,7 +123,7 @@ func (cmd DumpCmd) Exec(ctx context.Context, commandStr string, args []string, d
 		return HandleVErrAndExitCode(verr, usage)
 	}
 
-	tblNames, err := doltdb.GetNonSystemTableNames(ctx, root)
+	tblNames, err := doltdb.GetNonSystemTableNames(ctx, root, doltdb.HasDoltPrefix)
 	if err != nil {
 		return HandleVErrAndExitCode(errhand.BuildDError("error: failed to get tables").AddCause(err).Build(), usage)
 	}
@@ -325,7 +325,7 @@ func dumpProcedures(sqlCtx *sql.Context, engine *engine.SqlEngine, root doltdb.R
 }
 
 func dumpTriggers(sqlCtx *sql.Context, engine *engine.SqlEngine, root doltdb.RootValue, writer io.WriteCloser) (rerr error) {
-	_, _, ok, err := doltdb.GetTableInsensitive(sqlCtx, root, doltdb.TableName{Name: doltdb.SchemasTableName})
+	_, _, ok, err := doltdb.GetTableInsensitive(sqlCtx, root, doltdb.TableName{Name: doltdb.GetSchemasTableName()})
 	if err != nil {
 		return err
 	}
@@ -334,7 +334,7 @@ func dumpTriggers(sqlCtx *sql.Context, engine *engine.SqlEngine, root doltdb.Roo
 		return nil
 	}
 
-	sch, iter, _, err := engine.Query(sqlCtx, "select * from "+doltdb.SchemasTableName)
+	sch, iter, _, err := engine.Query(sqlCtx, "select * from "+doltdb.GetSchemasTableName())
 	if err != nil {
 		return err
 	}
@@ -391,7 +391,7 @@ func dumpTriggers(sqlCtx *sql.Context, engine *engine.SqlEngine, root doltdb.Roo
 }
 
 func dumpViews(ctx *sql.Context, engine *engine.SqlEngine, root doltdb.RootValue, writer io.WriteCloser) (rerr error) {
-	_, _, ok, err := doltdb.GetTableInsensitive(ctx, root, doltdb.TableName{Name: doltdb.SchemasTableName})
+	_, _, ok, err := doltdb.GetTableInsensitive(ctx, root, doltdb.TableName{Name: doltdb.GetSchemasTableName()})
 	if err != nil {
 		return err
 	}
@@ -400,7 +400,7 @@ func dumpViews(ctx *sql.Context, engine *engine.SqlEngine, root doltdb.RootValue
 		return nil
 	}
 
-	sch, iter, _, err := engine.Query(ctx, "select * from "+doltdb.SchemasTableName)
+	sch, iter, _, err := engine.Query(ctx, "select * from "+doltdb.GetSchemasTableName())
 	if err != nil {
 		return err
 	}

go/cmd/dolt/commands/merge.go

@@ -478,37 +478,38 @@ func calculateMergeStats(queryist cli.Queryist, sqlCtx *sql.Context, mergeStats
 	// get table operations
 	for _, summary := range diffSummaries {
 		// We want to ignore all statistics for Full-Text tables
-		if doltdb.IsFullTextTable(summary.TableName.Name) {
+		tableName := summary.TableName.Name
+		if doltdb.IsFullTextTable(tableName, doltdb.HasDoltPrefix(tableName)) {
 			continue
 		}
 		// Ignore stats for database collation changes
-		if strings.HasPrefix(summary.TableName.Name, diff.DBPrefix) {
+		if strings.HasPrefix(tableName, diff.DBPrefix) {
 			continue
 		}
 		if summary.DiffType == "added" {
 			allUnmodified = false
-			mergeStats[summary.TableName.Name] = &merge.MergeStats{
+			mergeStats[tableName] = &merge.MergeStats{
 				Operation: merge.TableAdded,
 			}
 		} else if summary.DiffType == "dropped" {
 			allUnmodified = false
-			mergeStats[summary.TableName.Name] = &merge.MergeStats{
+			mergeStats[tableName] = &merge.MergeStats{
 				Operation: merge.TableRemoved,
 			}
 		} else if summary.DiffType == "modified" || summary.DiffType == "renamed" {
 			allUnmodified = false
-			mergeStats[summary.TableName.Name] = &merge.MergeStats{
+			mergeStats[tableName] = &merge.MergeStats{
 				Operation: merge.TableModified,
 			}
-			tableStats, err := getTableDiffStats(queryist, sqlCtx, summary.TableName.Name, fromRef, toRef)
+			tableStats, err := getTableDiffStats(queryist, sqlCtx, tableName, fromRef, toRef)
 			if err != nil {
 				return nil, false, err
 			}
 			if tableStats != nil && len(tableStats) > 0 {
 				diffStats[tableStats[0].TableName] = tableStats[0]
 			}
 		} else {
-			mergeStats[summary.TableName.Name] = &merge.MergeStats{
+			mergeStats[tableName] = &merge.MergeStats{
 				Operation: merge.TableUnmodified,
 			}
 		}

go/cmd/dolt/commands/schcmds/export.go

@@ -127,7 +127,7 @@ func exportSchemas(ctx context.Context, apr *argparser.ArgParseResults, root dol
 		}
 		tablesToExport = []string{tblName}
 	} else {
-		tablesToExport, err = doltdb.GetNonSystemTableNames(ctx, root)
+		tablesToExport, err = doltdb.GetNonSystemTableNames(ctx, root, doltdb.HasDoltPrefix)
 		if err != nil {
 			return errhand.BuildDError("error retrieving table names").AddCause(err).Build()
 		}

go/cmd/dolt/commands/schcmds/show.go

@@ -142,7 +142,7 @@ func printSchemas(ctx context.Context, apr *argparser.ArgParseResults, dEnv *env
 
 		var notFound []string
 		for _, tblName := range tables {
-			if doltdb.IsFullTextTable(tblName) {
+			if doltdb.IsFullTextTable(tblName, doltdb.HasDoltPrefix(tblName)) {
 				continue
 			}
 			ok, err := root.HasTable(ctx, doltdb.TableName{Name: tblName})

go/cmd/dolt/commands/status.go

@@ -217,7 +217,7 @@ func createPrintData(err error, queryist cli.Queryist, sqlCtx *sql.Context, show
 				}
 				shouldIgnoreTable = ignored == doltdb.Ignore
 			}
-			shouldIgnoreTable = shouldIgnoreTable || doltdb.IsFullTextTable(tableName)
+			shouldIgnoreTable = shouldIgnoreTable || doltdb.IsFullTextTable(tableName, doltdb.HasDoltPrefix(tableName))
 
 			switch status {
 			case "renamed":
@@ -536,7 +536,7 @@ and have %v and %v different commits each, respectively.
 		cli.Println(stagedHeader)
 		cli.Println(stagedHeaderHelp)
 		for tableName, status := range data.stagedTables {
-			if !doltdb.IsReadOnlySystemTable(tableName) {
+			if !doltdb.IsReadOnlySystemTable(tableName, doltdb.HasDoltPrefix(tableName)) {
 				text := fmt.Sprintf(statusFmt, status+":", tableName)
 				greenText := color.GreenString(text)
 				cli.Println(greenText)

go/cmd/dolt/commands/tblcmds/rm.go

@@ -77,7 +77,7 @@ func (cmd RmCmd) Exec(ctx context.Context, commandStr string, args []string, dEn
 	}
 
 	for _, tableName := range apr.Args {
-		if doltdb.IsReadOnlySystemTable(tableName) {
+		if doltdb.IsReadOnlySystemTable(tableName, doltdb.HasDoltPrefix(tableName)) {
 			return commands.HandleVErrAndExitCode(
 				errhand.BuildDError("error removing table %s", tableName).AddCause(doltdb.ErrSystemTableCannotBeModified).Build(), usage)
 		}

go/libraries/doltcore/diff/table_deltas.go

@@ -449,6 +449,14 @@ func (td TableDelta) CurName() string {
 	return td.FromName.String()
 }
 
+// CurTableName returns the most recent TableName of the table.
+func (td TableDelta) CurTableName() doltdb.TableName {
+	if td.ToName.Name != "" {
+		return td.ToName
+	}
+	return td.FromName
+}
+
 func (td TableDelta) HasFKChanges() bool {
 	if len(td.FromFks) != len(td.ToFks) {
 		return true

go/libraries/doltcore/doltdb/system_table.go

@@ -63,48 +63,47 @@ func HasDoltCIPrefix(s string) bool {
 
 // IsFullTextTable returns a boolean stating whether the given table is one of the pseudo-index tables used by Full-Text
 // indexes.
-// TODO: Schema name
-func IsFullTextTable(name string) bool {
-	return HasDoltPrefix(name) && (strings.HasSuffix(name, "_fts_config") ||
+func IsFullTextTable(name string, isSystemTable bool) bool {
+	return isSystemTable && (strings.HasSuffix(name, "_fts_config") ||
 		strings.HasSuffix(name, "_fts_position") ||
 		strings.HasSuffix(name, "_fts_doc_count") ||
 		strings.HasSuffix(name, "_fts_global_count") ||
 		strings.HasSuffix(name, "_fts_row_count"))
 }
 
 // IsDoltCITable returns whether the table name given is a dolt-ci table
-func IsDoltCITable(name string) bool {
-	return HasDoltCIPrefix(name) && set.NewStrSet(getWriteableSystemTables()).Contains(name) && !IsFullTextTable(name)
+func IsDoltCITable(name string, isSystemTable bool) bool {
+	return HasDoltCIPrefix(name) && set.NewStrSet(getWriteableSystemTables()).Contains(name) && !IsFullTextTable(name, isSystemTable)
 }
 
 // IsReadOnlySystemTable returns whether the table name given is a system table that should not be included in command line
 // output (e.g. dolt status) by default.
-func IsReadOnlySystemTable(name string) bool {
-	return HasDoltPrefix(name) && !set.NewStrSet(getWriteableSystemTables()).Contains(name) && !IsFullTextTable(name)
+func IsReadOnlySystemTable(name string, isSystemTable bool) bool {
+	return isSystemTable && !set.NewStrSet(getWriteableSystemTables()).Contains(name) && !IsFullTextTable(name, isSystemTable)
 }
 
 // IsNonAlterableSystemTable returns whether the table name given is a system table that cannot be dropped or altered
 // by the user.
-func IsNonAlterableSystemTable(name string) bool {
-	return (IsReadOnlySystemTable(name) && !IsFullTextTable(name)) || strings.EqualFold(name, SchemasTableName)
+func IsNonAlterableSystemTable(name string, isSystemTable bool) bool {
+	return (IsReadOnlySystemTable(name, isSystemTable) && !IsFullTextTable(name, isSystemTable)) || strings.EqualFold(name, GetSchemasTableName())
 }
 
 // GetNonSystemTableNames gets non-system table names
-func GetNonSystemTableNames(ctx context.Context, root RootValue) ([]string, error) {
+func GetNonSystemTableNames(ctx context.Context, root RootValue, isSystemTableFn func(n string) bool) ([]string, error) {
 	tn, err := root.GetTableNames(ctx, DefaultSchemaName)
 	if err != nil {
 		return nil, err
 	}
 	tn = funcitr.FilterStrings(tn, func(n string) bool {
-		return !HasDoltPrefix(n)
+		return !isSystemTableFn(n)
 	})
 	sort.Strings(tn)
 	return tn, nil
 }
 
 // GetSystemTableNames gets system table names
-func GetSystemTableNames(ctx context.Context, root RootValue) ([]string, error) {
-	p, err := GetPersistedSystemTables(ctx, root)
+func GetSystemTableNames(ctx context.Context, root RootValue, isSystemTableFn func(n string) bool) ([]string, error) {
+	p, err := GetPersistedSystemTables(ctx, root, isSystemTableFn)
 	if err != nil {
 		return nil, err
 	}
@@ -121,13 +120,13 @@ func GetSystemTableNames(ctx context.Context, root RootValue) ([]string, error)
 }
 
 // GetPersistedSystemTables returns table names of all persisted system tables.
-func GetPersistedSystemTables(ctx context.Context, root RootValue) ([]string, error) {
+func GetPersistedSystemTables(ctx context.Context, root RootValue, isSystemTableFn func(n string) bool) ([]string, error) {
 	tn, err := root.GetTableNames(ctx, DefaultSchemaName)
 	if err != nil {
 		return nil, err
 	}
 	sort.Strings(tn)
-	return funcitr.FilterStrings(tn, HasDoltPrefix), nil
+	return funcitr.FilterStrings(tn, isSystemTableFn), nil
 }
 
 // GetGeneratedSystemTables returns table names of all generated system tables.
@@ -153,7 +152,7 @@ var getWriteableSystemTables = func() []string {
 	return []string{
 		GetDocTableName(),
 		DoltQueryCatalogTableName,
-		SchemasTableName,
+		GetSchemasTableName(),
 		GetProceduresTableName(),
 		IgnoreTableName,
 		RebaseTableName,