Skip to content

enable adaptive encoding with an env var#10791

Merged
zachmu merged 12 commits intomainfrom
zachmu/adaptive
Apr 1, 2026
Merged

enable adaptive encoding with an env var#10791
zachmu merged 12 commits intomainfrom
zachmu/adaptive

Conversation

@zachmu
Copy link
Copy Markdown
Member

@zachmu zachmu commented Mar 31, 2026

Added new CI configurations to exercise this code path.

Also added a compatibility-breaking changes to prevent older dolt clients from misinterpreting adaptive encoded values.

@zachmu zachmu requested a review from reltuk March 31, 2026 23:07
@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented Mar 31, 2026

@zachmu DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.55 0.55 0.0
groupby_scan 9.91 9.91 0.0
index_join 1.86 1.86 0.0
index_join_scan 1.37 1.37 0.0
index_scan 22.28 22.69 1.84
oltp_point_select 0.27 0.27 0.0
oltp_read_only 5.28 5.28 0.0
select_random_points 0.54 0.54 0.0
select_random_ranges 0.56 0.55 -1.79
table_scan 22.28 22.69 1.84
types_table_scan 66.84 68.05 1.81
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.32 0.0
oltp_insert 3.13 3.13 0.0
oltp_read_write 11.45 11.45 0.0
oltp_update_index 3.19 3.19 0.0
oltp_update_non_index 3.13 3.13 0.0
oltp_write_only 6.09 6.09 0.0
types_delete_insert 6.91 6.91 0.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e51012b ok 5937471
version total_tests
e51012b 5937471
correctness_percentage
100.0

Copy link
Copy Markdown
Contributor

@reltuk reltuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented Mar 31, 2026

@zachmu DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 56.84 58.92 3.66
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt 2662362 42.73 dolt f445758 42.54 -0.44

@coffeegoddd
Copy link
Copy Markdown
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
7e4ff4b ok 5937471
version total_tests
7e4ff4b 5937471
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
f445758 ok 5937471
version total_tests
f445758 5937471
correctness_percentage
100.0

@zachmu zachmu merged commit 3b76f56 into main Apr 1, 2026
31 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants