Skip to content

Commit c74976b

Browse files
committed
Tests passing
1 parent f6cf62c commit c74976b

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

server/connection_handler.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import (
2929

3030
"github.com/dolthub/dolt/go/libraries/doltcore/sqle/dsess"
3131
"github.com/dolthub/dolt/go/libraries/doltcore/sqlserver"
32+
"github.com/dolthub/go-mysql-server/server"
3233
"github.com/dolthub/go-mysql-server/sql"
3334
"github.com/dolthub/vitess/go/mysql"
3435
"github.com/dolthub/vitess/go/vt/sqlparser"
@@ -87,7 +88,7 @@ func init() {
8788
}
8889

8990
// NewConnectionHandler returns a new ConnectionHandler for the connection provided
90-
func NewConnectionHandler(conn net.Conn, handler mysql.Handler) *ConnectionHandler {
91+
func NewConnectionHandler(conn net.Conn, handler mysql.Handler, sel server.ServerEventListener) *ConnectionHandler {
9192
mysqlConn := &mysql.Conn{
9293
Conn: conn,
9394
PrepareData: make(map[uint32]*mysql.PrepareData),
@@ -111,9 +112,9 @@ func NewConnectionHandler(conn net.Conn, handler mysql.Handler) *ConnectionHandl
111112
encodeLoggedQuery: false, // cfg.EncodeLoggedQuery,
112113
pgTypeMap: pgtype.NewMap(),
113114
}
114-
// if csqlserver.MetricsListener != nil {
115-
// doltgresHandler.sel = csqlserver.MetricsListener
116-
// }
115+
if sel != nil {
116+
doltgresHandler.sel = sel
117+
}
117118

118119
return &ConnectionHandler{
119120
mysqlConn: mysqlConn,

server/listener.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ var (
3535
type Listener struct {
3636
listener net.Listener
3737
cfg mysql.ListenerConfig
38+
sel server.ServerEventListener
3839
}
3940

4041
var _ server.ProtocolListener = (*Listener)(nil)
@@ -48,14 +49,15 @@ func WithCertificate(cert tls.Certificate) ListenerOpt {
4849
}
4950

5051
// NewListener creates a new Listener.
51-
func NewListener(listenerCfg mysql.ListenerConfig) (server.ProtocolListener, error) {
52-
return NewListenerWithOpts(listenerCfg)
52+
func NewListener(listenerCfg mysql.ListenerConfig, sel server.ServerEventListener) (server.ProtocolListener, error) {
53+
return NewListenerWithOpts(listenerCfg, sel)
5354
}
5455

55-
func NewListenerWithOpts(listenerCfg mysql.ListenerConfig, opts ...ListenerOpt) (server.ProtocolListener, error) {
56+
func NewListenerWithOpts(listenerCfg mysql.ListenerConfig, sel server.ServerEventListener, opts ...ListenerOpt) (server.ProtocolListener, error) {
5657
l := &Listener{
5758
listener: listenerCfg.Listener,
5859
cfg: listenerCfg,
60+
sel: sel,
5961
}
6062

6163
for _, opt := range opts {
@@ -83,7 +85,7 @@ func (l *Listener) Accept() {
8385
conn = netutil.NewConnWithTimeouts(conn, l.cfg.ConnReadTimeout, l.cfg.ConnWriteTimeout)
8486
}
8587

86-
connectionHandler := NewConnectionHandler(conn, l.cfg.Handler)
88+
connectionHandler := NewConnectionHandler(conn, l.cfg.Handler, l.sel)
8789
go connectionHandler.HandleConnection()
8890
}
8991
}

testing/go/ssl_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ type SSLListener struct {
2323
*dserver.Listener
2424
}
2525

26-
func NewSslListener(listenerCfg mysql.ListenerConfig) (server.ProtocolListener, error) {
26+
func NewSslListener(listenerCfg mysql.ListenerConfig, sel server.ServerEventListener) (server.ProtocolListener, error) {
2727
// Since this is intended for testing, we'll configure a test certificate so that we can test for SSL support
2828
cert, key, err := testcerts.GenerateCerts()
2929
if err != nil {
@@ -35,7 +35,7 @@ func NewSslListener(listenerCfg mysql.ListenerConfig) (server.ProtocolListener,
3535
panic(err)
3636
}
3737

38-
listener, err := dserver.NewListenerWithOpts(listenerCfg, dserver.WithCertificate(certificate))
38+
listener, err := dserver.NewListenerWithOpts(listenerCfg, sel, dserver.WithCertificate(certificate))
3939
if err != nil {
4040
return nil, err
4141
}

0 commit comments

Comments
 (0)