Merge pull request #1473 from dolthub/zachmu/name-resolution

Bug fixes for `EXISTS`, prepared statement typing

Author: zachmu

go.mod

@@ -10,9 +10,9 @@ require (
 	github.com/dolthub/dolt/go/gen/proto/dolt/services/eventsapi v0.0.0-20241119094239-f4e529af734d
 	github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2
 	github.com/dolthub/go-icu-regex v0.0.0-20250327004329-6799764f2dad
-	github.com/dolthub/go-mysql-server v0.19.1-0.20250512071951-e13f1e516493
+	github.com/dolthub/go-mysql-server v0.20.1-0.20250514213318-e116aa682aaf
 	github.com/dolthub/sqllogictest/go v0.0.0-20240618184124-ca47f9354216
-	github.com/dolthub/vitess v0.0.0-20250508181115-8941c8d71af1
+	github.com/dolthub/vitess v0.0.0-20250512224608-8fb9c6ea092c
 	github.com/fatih/color v1.13.0
 	github.com/goccy/go-json v0.10.2
 	github.com/gogo/protobuf v1.3.2

go.sum

@@ -266,8 +266,8 @@ github.com/dolthub/fslock v0.0.3 h1:iLMpUIvJKMKm92+N1fmHVdxJP5NdyDK5bK7z7Ba2s2U=
 github.com/dolthub/fslock v0.0.3/go.mod h1:QWql+P17oAAMLnL4HGB5tiovtDuAjdDTPbuqx7bYfa0=
 github.com/dolthub/go-icu-regex v0.0.0-20250327004329-6799764f2dad h1:66ZPawHszNu37VPQckdhX1BPPVzREsGgNxQeefnlm3g=
 github.com/dolthub/go-icu-regex v0.0.0-20250327004329-6799764f2dad/go.mod h1:ylU4XjUpsMcvl/BKeRRMXSH7e7WBrPXdSLvnRJYrxEA=
-github.com/dolthub/go-mysql-server v0.19.1-0.20250512071951-e13f1e516493 h1:0bC4Bi4lnP5WOQzZFK/McYk9kFty3+tJfmsRwWYRGnQ=
-github.com/dolthub/go-mysql-server v0.19.1-0.20250512071951-e13f1e516493/go.mod h1:3ItecPpGxpYrvkofINdXpIXMS7SH1NXAeOSfPFj03wE=
+github.com/dolthub/go-mysql-server v0.20.1-0.20250514213318-e116aa682aaf h1:sYBhIXdvdBww8Xw6K1QMjmGbuFEfYefNBie65TOxdm0=
+github.com/dolthub/go-mysql-server v0.20.1-0.20250514213318-e116aa682aaf/go.mod h1:5ZdrW0fHZbz+8CngT9gksqSX4H3y+7v1pns7tJCEpu0=
 github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63 h1:OAsXLAPL4du6tfbBgK0xXHZkOlos63RdKYS3Sgw/dfI=
 github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63/go.mod h1:lV7lUeuDhH5thVGDCKXbatwKy2KW80L4rMT46n+Y2/Q=
 github.com/dolthub/ishell v0.0.0-20240701202509-2b217167d718 h1:lT7hE5k+0nkBdj/1UOSFwjWpNxf+LCApbRHgnCA17XE=
@@ -276,8 +276,8 @@ github.com/dolthub/jsonpath v0.0.2-0.20240227200619-19675ab05c71 h1:bMGS25NWAGTE
 github.com/dolthub/jsonpath v0.0.2-0.20240227200619-19675ab05c71/go.mod h1:2/2zjLQ/JOOSbbSboojeg+cAwcRV0fDLzIiWch/lhqI=
 github.com/dolthub/sqllogictest/go v0.0.0-20240618184124-ca47f9354216 h1:JWkKRE4EHUcEVQCMRBej8DYxjYjRz/9MdF/NNQh0o70=
 github.com/dolthub/sqllogictest/go v0.0.0-20240618184124-ca47f9354216/go.mod h1:e/FIZVvT2IR53HBCAo41NjqgtEnjMJGKca3Y/dAmZaA=
-github.com/dolthub/vitess v0.0.0-20250508181115-8941c8d71af1 h1:kH6+SaEzpm9QFKqWsznzwxcYrXIB4HZq6yOaZSXwsng=
-github.com/dolthub/vitess v0.0.0-20250508181115-8941c8d71af1/go.mod h1:1gQZs/byeHLMSul3Lvl3MzioMtOW1je79QYGyi2fd70=
+github.com/dolthub/vitess v0.0.0-20250512224608-8fb9c6ea092c h1:imdag6PPCHAO2rZNsFoQoR4I/vIVTmO/czoOl5rUnbk=
+github.com/dolthub/vitess v0.0.0-20250512224608-8fb9c6ea092c/go.mod h1:1gQZs/byeHLMSul3Lvl3MzioMtOW1je79QYGyi2fd70=
 github.com/dustin/go-humanize v0.0.0-20171111073723-bb3d318650d4/go.mod h1:HtrtbFcZ19U5GC7JDqmcUSB87Iq5E25KnS6fMYU6eOk=
 github.com/dustin/go-humanize v1.0.0/go.mod h1:HtrtbFcZ19U5GC7JDqmcUSB87Iq5E25KnS6fMYU6eOk=
 github.com/dustin/go-humanize v1.0.1 h1:GzkhY7T5VNhEkwH0PVJgjz+fX1rhBrR7pRT3mDkpeCY=

server/analyzer/type_sanitizer.go

@@ -74,6 +74,8 @@ func TypeSanitizer(ctx *sql.Context, a *analyzer.Analyzer, node sql.Node, scope
 					}
 				}
 			}
+		case *plan.ExistsSubquery:
+			return pgexprs.NewGMSCast(expr), transform.NewTree, nil
 		case *sql.ColumnDefaultValue:
 			// Due to how interfaces work, we sometimes pass (*ColumnDefaultValue)(nil), so we have to check for it
 			if expr != nil && expr.Expr != nil {

server/connection_data.go

@@ -132,6 +132,8 @@ func extractBindVarTypes(queryPlan sql.Node) ([]uint32, error) {
 				switch n.(type) {
 				case *plan.Limit:
 					typOid = uint32(oid.T_int4)
+				case *plan.Offset:
+					typOid = uint32(oid.T_int4)
 				default:
 					typOid, err = VitessTypeToObjectID(e.Type().Type())
 					if err != nil {
@@ -241,6 +243,8 @@ func VitessTypeToObjectID(typ query.Type) (uint32, error) {
 		return uint32(oid.T_text), nil // NULL is treated as TEXT on the wire
 	case query.Type_ENUM:
 		return uint32(oid.T_text), nil // TODO: temporary solution until we support CREATE TYPE
+	case query.Type_EXPRESSION:
+		return uint32(oid.T_text), nil // this most closely matches the behavior in postgres, which treats any unresolved type as a string (unless it has special handling)
 	default:
 		return 0, errors.Errorf("unsupported type: %s", typ)
 	}

testing/go/prepared_statement_test.go

@@ -48,6 +48,13 @@ var preparedStatementTests = []ScriptTest{
 					{3},
 				},
 			},
+			{
+				Query:    "select $1 as test",
+				BindVars: []any{"hello"},
+				Expected: []sql.Row{
+					{"hello"},
+				},
+			},
 		},
 	},
 	{
@@ -56,18 +63,21 @@ var preparedStatementTests = []ScriptTest{
 			{
 				Query:    "SELECT EXISTS(SELECT 1 FROM pg_namespace WHERE nspname = $1);",
 				BindVars: []any{"public"},
-				Expected: []sql.Row{{1}},
+				Expected: []sql.Row{{"t"}},
 			},
 			{
 				Query:    "SELECT nspname FROM pg_namespace LIMIT $1;",
 				BindVars: []any{1},
 				Expected: []sql.Row{{"dolt"}},
 			},
 			{
-				Skip:     true, // TODO: ERROR: unsupported syntax: <nil>
 				Query:    "SELECT nspname FROM pg_namespace OFFSET $1;",
 				BindVars: []any{1},
-				Expected: []sql.Row{{"dolt"}},
+				Expected: []sql.Row{
+					{"information_schema"},
+					{"pg_catalog"},
+					{"public"},
+				},
 			},
 		},
 	},