Skip to content

Conversation

@zachmu
Copy link
Member

@zachmu zachmu commented May 30, 2025

Depends on dolthub/go-mysql-server#3001

This invalidates the previous approach, but I want feedback on this technique before I remove it.

@zachmu zachmu requested a review from Hydrocharged May 30, 2025 01:11
@github-actions
Copy link
Contributor

github-actions bot commented May 30, 2025

Main PR
covering_index_scan_postgres 331.82/s 335.88/s +1.2%
index_join_postgres 156.66/s 158.46/s +1.1%
index_join_scan_postgres 188.13/s 188.45/s +0.1%
index_scan_postgres 12.37/s 12.40/s +0.2%
oltp_point_select 2537.33/s 2545.73/s +0.3%
oltp_read_only 1840.64/s 1839.85/s -0.1%
select_random_points 118.44/s 118.82/s +0.3%
select_random_ranges 130.63/s 133.37/s +2.0%
table_scan_postgres 11.80/s 11.90/s +0.8%
types_table_scan_postgres 5.49/s 5.55/s +1.0%

@github-actions
Copy link
Contributor

Main PR
Total 42090 42090
Successful 16442 16447
Failures 25648 25643
Partial Successes1 5549 5549
Main PR
Successful 39.0639% 39.0758%
Failures 60.9361% 60.9242%

${\color{lightgreen}Progressions (5)}$

aggregates

QUERY: select array_agg(a order by b)
  from (values (1,4),(2,3),(3,1),(4,2)) v(a,b);
QUERY: select array_agg(a order by a)
  from (values (1,4),(2,3),(3,1),(4,2)) v(a,b);
QUERY: select array_agg(a order by a desc)
  from (values (1,4),(2,3),(3,1),(4,2)) v(a,b);
QUERY: select array_agg(b order by a desc)
  from (values (1,4),(2,3),(3,1),(4,2)) v(a,b);

arrays

QUERY: select array_agg(nullif(ten, 4)) from (select ten from tenk1 where unique1 < 15 order by unique1) ss;

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@zachmu zachmu requested a review from fulghum May 30, 2025 19:08
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some high level comments in the vitess PR, but overall this seems like a practical approach to get more support for aggregation functions.

@zachmu zachmu enabled auto-merge May 31, 2025 00:15
@zachmu zachmu merged commit 9a22145 into main May 31, 2025
14 checks passed
@zachmu zachmu deleted the zachmu/array_agg2 branch May 31, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants