-
-
Notifications
You must be signed in to change notification settings - Fork 39
Support for ORDER BY in array_agg #1515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
fulghum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some high level comments in the vitess PR, but overall this seems like a practical approach to get more support for aggregation functions.
Co-authored-by: Jason Fulghum <[email protected]>
Depends on dolthub/go-mysql-server#3001
This invalidates the previous approach, but I want feedback on this technique before I remove it.