Skip to content

dolthub/dolt#1374: Fix pg_catalog test expectations to include new author columns for dolt_log #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

dolthub/dolt#1374: Fix pg_catalog test expectations to include new author columns for dolt_log #2039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d8534f
fix pg catalog dolt_log missing author cols
elianddb Nov 19, 2025
cc192d7
amend dolt/go ver. to use dolthub/dolt@elian/1374
elianddb Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ require (
github.com/PuerkitoBio/goquery v1.8.1
github.com/cockroachdb/apd/v2 v2.0.3-0.20200518165714-d020e156310a
github.com/cockroachdb/errors v1.7.5
github.com/dolthub/dolt/go v0.40.5-0.20251114235135-db2b209c8801
github.com/dolthub/dolt/go v0.40.5-0.20251119201805-a7811ea8a037
github.com/dolthub/eventsapi_schema v0.0.0-20250915094920-eadfd39051ca
github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2
github.com/dolthub/go-mysql-server v0.20.1-0.20251114214131-16344edab8e2
github.com/dolthub/go-mysql-server v0.20.1-0.20251118232608-f06d88560cc2
github.com/dolthub/sqllogictest/go v0.0.0-20240618184124-ca47f9354216
github.com/dolthub/vitess v0.0.0-20251107003339-843d10a6a8d4
github.com/fatih/color v1.13.0
Expand Down
8 changes: 4 additions & 4 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ github.com/dolthub/aws-sdk-go-ini-parser v0.0.0-20250305001723-2821c37f6c12 h1:I
github.com/dolthub/aws-sdk-go-ini-parser v0.0.0-20250305001723-2821c37f6c12/go.mod h1:rN7X8BHwkjPcfMQQ2QTAq/xM3leUSGLfb+1Js7Y6TVo=
github.com/dolthub/dolt-mcp v0.2.2 h1:bpROmam74n95uU4EA3BpOIVlTDT0pzeFMBwe/YRq2mI=
github.com/dolthub/dolt-mcp v0.2.2/go.mod h1:S++DJ4QWTAXq+0TNzFa7Oq3IhoT456DJHwAINFAHgDQ=
github.com/dolthub/dolt/go v0.40.5-0.20251114235135-db2b209c8801 h1:NAViuC5niRPPEmANezASEx/x7O3Qm2F7eVzFEyC7T2Q=
github.com/dolthub/dolt/go v0.40.5-0.20251114235135-db2b209c8801/go.mod h1:SDpAhw55jOXKLP3+gbH9HSRanpFQ8P41dNxF1sqstWc=
github.com/dolthub/dolt/go v0.40.5-0.20251119201805-a7811ea8a037 h1:smDc3Zn65WfMwJq4hDV8mbZh1GooDXAysq+2tUxR7sA=
github.com/dolthub/dolt/go v0.40.5-0.20251119201805-a7811ea8a037/go.mod h1:2iQTeomQsRyfXYkpjuxGfOL+KIhB9JDmBBZEUYpzUDo=
github.com/dolthub/eventsapi_schema v0.0.0-20250915094920-eadfd39051ca h1:BGFz/0OlKIuC6qHIZQbvPapFvdAJkeEyGXWVgL5clmE=
github.com/dolthub/eventsapi_schema v0.0.0-20250915094920-eadfd39051ca/go.mod h1:CoDLfgPqHyBtth0Cp+fi/CmC4R81zJNX4wPjShdZ+Bw=
github.com/dolthub/flatbuffers/v23 v23.3.3-dh.2 h1:u3PMzfF8RkKd3lB9pZ2bfn0qEG+1Gms9599cr0REMww=
Expand All @@ -238,8 +238,8 @@ github.com/dolthub/fslock v0.0.3 h1:iLMpUIvJKMKm92+N1fmHVdxJP5NdyDK5bK7z7Ba2s2U=
github.com/dolthub/fslock v0.0.3/go.mod h1:QWql+P17oAAMLnL4HGB5tiovtDuAjdDTPbuqx7bYfa0=
github.com/dolthub/go-icu-regex v0.0.0-20250916051405-78a38d478790 h1:zxMsH7RLiG+dlZ/y0LgJHTV26XoiSJcuWq+em6t6VVc=
github.com/dolthub/go-icu-regex v0.0.0-20250916051405-78a38d478790/go.mod h1:F3cnm+vMRK1HaU6+rNqQrOCyR03HHhR1GWG2gnPOqaE=
github.com/dolthub/go-mysql-server v0.20.1-0.20251114214131-16344edab8e2 h1:ODaw/BUzhvNhHjcDFCmsMIBrnFnRJX19O78Z9kJ+M6g=
github.com/dolthub/go-mysql-server v0.20.1-0.20251114214131-16344edab8e2/go.mod h1:HTOKSMPJWcbSgCe1DksDgNPlZyZP1usV+EoA7Utax+A=
github.com/dolthub/go-mysql-server v0.20.1-0.20251118232608-f06d88560cc2 h1:FGVjkA6MdVZcMD4dNVQhXhTN/nMJc+0tqBGUTvlWb/g=
github.com/dolthub/go-mysql-server v0.20.1-0.20251118232608-f06d88560cc2/go.mod h1:HTOKSMPJWcbSgCe1DksDgNPlZyZP1usV+EoA7Utax+A=
github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63 h1:OAsXLAPL4du6tfbBgK0xXHZkOlos63RdKYS3Sgw/dfI=
github.com/dolthub/gozstd v0.0.0-20240423170813-23a2903bca63/go.mod h1:lV7lUeuDhH5thVGDCKXbatwKy2KW80L4rMT46n+Y2/Q=
github.com/dolthub/ishell v0.0.0-20240701202509-2b217167d718 h1:lT7hE5k+0nkBdj/1UOSFwjWpNxf+LCApbRHgnCA17XE=
Expand Down
15 changes: 15 additions & 0 deletions testing/go/pgcatalog_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5366,6 +5366,9 @@ WHERE pg_catalog.pg_class.relkind = ANY (ARRAY['r', 'p', 'f', 'v', 'm']) AND pg_
{"date", "timestamp without time zone", nil, "t", "dolt_log", nil, "", nil},
{"message", "text", nil, "t", "dolt_log", nil, "", nil},
{"commit_order", "bigint", nil, "t", "dolt_log", nil, "", nil},
{"author", "text", nil, "t", "dolt_log", nil, "", nil},
{"author_email", "text", nil, "t", "dolt_log", nil, "", nil},
{"author_date", "timestamp without time zone", nil, "t", "dolt_log", nil, "", nil},
},
},
},
Expand Down Expand Up @@ -5436,6 +5439,9 @@ JOIN pg_catalog.pg_namespace ON pg_catalog.pg_namespace.oid = pg_catalog.pg_type
{"date", "timestamp without time zone", nil, "t", "dolt_log", nil, "", nil},
{"message", "text", nil, "t", "dolt_log", nil, "", nil},
{"commit_order", "bigint", nil, "t", "dolt_log", nil, "", nil},
{"author", "text", nil, "t", "dolt_log", nil, "", nil},
{"author_email", "text", nil, "t", "dolt_log", nil, "", nil},
{"author_date", "timestamp without time zone", nil, "t", "dolt_log", nil, "", nil},
},
},
},
Expand Down Expand Up @@ -5905,6 +5911,9 @@ func TestSystemTablesInPgcatalog(t *testing.T) {
{909123395, "date", 1114, 4, "t", "f", "f"},
{909123395, "message", 25, 5, "t", "f", "f"},
{909123395, "commit_order", 20, 6, "t", "f", "f"},
{909123395, "author", 25, 7, "t", "f", "f"},
{909123395, "author_email", 25, 8, "t", "f", "f"},
{909123395, "author_date", 1114, 9, "t", "f", "f"},
{1060579466, "table_name", 25, 1, "t", "f", "f"},
{1060579466, "staged", 16, 2, "t", "f", "f"},
{1060579466, "status", 25, 3, "t", "f", "f"},
Expand Down Expand Up @@ -5974,6 +5983,9 @@ func TestSystemTablesInPgcatalog(t *testing.T) {
{2067982358, "date", 1114, 4, "t", "f", "f"},
{2067982358, "message", 25, 5, "t", "f", "f"},
{2067982358, "commit_order", 20, 6, "t", "f", "f"},
{2067982358, "author", 25, 7, "t", "f", "f"},
{2067982358, "author_email", 25, 8, "t", "f", "f"},
{2067982358, "author_date", 1114, 9, "t", "f", "f"},
{2357712556, "commit_hash", 25, 1, "t", "f", "f"},
{2357712556, "table_name", 25, 2, "t", "f", "f"},
{2357712556, "committer", 25, 3, "t", "f", "f"},
Expand Down Expand Up @@ -6041,6 +6053,9 @@ func TestSystemTablesInPgcatalog(t *testing.T) {
{3491847678, "date", 1114, 4, "t", "f", "f"},
{3491847678, "message", 25, 5, "t", "f", "f"},
{3491847678, "commit_order", 20, 6, "t", "f", "f"},
{3491847678, "author", 25, 7, "t", "f", "f"},
{3491847678, "author_email", 25, 8, "t", "f", "f"},
{3491847678, "author_date", 1114, 9, "t", "f", "f"},
{3554775706, "table_name", 25, 1, "t", "f", "f"},
{3554775706, "staged", 16, 2, "t", "f", "f"},
{3554775706, "status", 25, 3, "t", "f", "f"},
Expand Down