Skip to content

tests for cross-schema foreign keys #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 25, 2024
Merged

tests for cross-schema foreign keys #878

merged 11 commits into from
Oct 25, 2024

Conversation

@zachmu
Copy link
Member

@zachmu zachmu commented Oct 22, 2024

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

Main PR
Total 42090 42090
Successful 12876 12876
Failures 29214 29214
Partial Successes1 4892 4892
Main PR
Successful 30.5916% 30.5916%
Failures 69.4084% 69.4084%

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct. ↩

@zachmu zachmu requested a review from Hydrocharged October 22, 2024 23:59
Hydrocharged
Hydrocharged approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zachmu zachmu enabled auto-merge October 25, 2024 00:50
@zachmu zachmu merged commit f1757f8 into main Oct 25, 2024
13 checks passed
@zachmu zachmu deleted the zachmu/cross-schema-fks branch October 25, 2024 00:58
@BrewTestBot BrewTestBot mentioned this pull request Nov 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hydrocharged Hydrocharged Hydrocharged approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zachmu @Hydrocharged