fix dropped err

jennifersp · jennifersp · commit 01a6dd341d8c · 2024-11-14T14:23:00.000-08:00
diff --git a/sql/analyzer/optimization_rules.go b/sql/analyzer/optimization_rules.go
@@ -338,7 +338,7 @@ func simplifyFilters(ctx *sql.Context, a *Analyzer, node sql.Node, scope *plan.S
 				// All other expressions types can be evaluated once and turned into literals for the rest of query execution
 				val, err := e.Eval(ctx, nil)
 				if err != nil {
-					return e, transform.SameTree, nil
+					return e, transform.SameTree, err
 				}
 				return expression.NewLiteral(val, e.Type()), transform.NewTree, nil
 			}

Original file line number	Diff line number	Diff line change
`@@ -338,7 +338,7 @@ func simplifyFilters(ctx sql.Context, a Analyzer, node sql.Node, scope *plan.S`
`338`	`338`	`// All other expressions types can be evaluated once and turned into literals for the rest of query execution`
`339`	`339`	`val, err := e.Eval(ctx, nil)`
`340`	`340`	`if err != nil {`
`341`		`- return e, transform.SameTree, nil`
	`341`	`+ return e, transform.SameTree, err`
`342`	`342`	`}`
`343`	`343`	`return expression.NewLiteral(val, e.Type()), transform.NewTree, nil`
`344`	`344`	`}`