clean up

Author: James Cor

sql/core.go

@@ -465,7 +465,7 @@ type ValueExpression interface {
 	Expression
 	// EvalValue evaluates the given row frame and returns a result.
 	EvalValue(ctx *Context, row ValueRow) (Value, error)
-	// CanSupport indicates whether this expression and all it's children support ValueExpression.
+	// CanSupport indicates whether this expression and all its children support ValueExpression.
 	CanSupport() bool
 }
 

sql/plan/filter.go

@@ -136,6 +136,7 @@ func (i *FilterIter) Next(ctx *sql.Context) (sql.Row, error) {
 	}
 }
 
+// NextValueRow implements the sql.ValueRowIter interface.
 func (i *FilterIter) NextValueRow(ctx *sql.Context) (sql.ValueRow, error) {
 	for {
 		row, err := i.childIter.(sql.ValueRowIter).NextValueRow(ctx)

sql/plan/process.go

@@ -317,6 +317,7 @@ func (i *TrackedRowIter) Next(ctx *sql.Context) (sql.Row, error) {
 	return row, nil
 }
 
+// NextValueRow implements the sql.ValueRowIter interface.
 func (i *TrackedRowIter) NextValueRow(ctx *sql.Context) (sql.ValueRow, error) {
 	row, err := i.iter.(sql.ValueRowIter).NextValueRow(ctx)
 	if err != nil {
@@ -329,6 +330,7 @@ func (i *TrackedRowIter) NextValueRow(ctx *sql.Context) (sql.ValueRow, error) {
 	return row, nil
 }
 
+// CanSupport implements the sql.ValueRowIter interface.
 func (i *TrackedRowIter) CanSupport(ctx *sql.Context) bool {
 	iter, ok := i.iter.(sql.ValueRowIter)
 	return ok && iter.CanSupport(ctx)

sql/rowexec/transaction_iters.go

@@ -99,10 +99,12 @@ func (t *TransactionCommittingIter) Next(ctx *sql.Context) (sql.Row, error) {
 	return t.childIter.Next(ctx)
 }
 
+// NextValueRow implements the sql.ValueRowIter interface.
 func (t *TransactionCommittingIter) NextValueRow(ctx *sql.Context) (sql.ValueRow, error) {
 	return t.childIter.(sql.ValueRowIter).NextValueRow(ctx)
 }
 
+// CanSupport implements the sql.ValueRowIter interface.
 func (t *TransactionCommittingIter) CanSupport(ctx *sql.Context) bool {
 	childIter, ok := t.childIter.(sql.ValueRowIter)
 	return ok && childIter.CanSupport(ctx)

sql/table_iter.go

@@ -116,6 +116,7 @@ func (i *TableRowIter) NextValueRow(ctx *Context) (ValueRow, error) {
 	return row, err
 }
 
+// CanSupport implements the sql.ValueRowIter interface.
 func (i *TableRowIter) CanSupport(ctx *Context) bool {
 	if i.partition == nil {
 		partition, err := i.partitions.Next(ctx)