Skip to content

Commit 0ce9650

Browse files
author
James Cor
committed
fix
1 parent b014b87 commit 0ce9650

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

enginetest/memory_engine_test.go

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -202,15 +202,23 @@ func TestSingleQueryPrepared(t *testing.T) {
202202

203203
// Convenience test for debugging a single query. Unskip and set to the desired query.
204204
func TestSingleScript(t *testing.T) {
205-
//t.Skip()
205+
t.Skip()
206206
var scripts = []queries.ScriptTest{
207207
{
208-
Name: "test",
208+
Name: "AS OF propagates to nested CALLs",
209209
SetUpScript: []string{},
210210
Assertions: []queries.ScriptTestAssertion{
211211
{
212-
Query: "select @@hostname, @@port, @@max_connections",
213-
Expected: []sql.Row{},
212+
Query: "create procedure create_proc() create table t (i int primary key, j int);",
213+
Expected: []sql.Row{
214+
{types.NewOkResult(0)},
215+
},
216+
},
217+
{
218+
Query: "call create_proc()",
219+
Expected: []sql.Row{
220+
{types.NewOkResult(0)},
221+
},
214222
},
215223
},
216224
},

server/server.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,17 +137,15 @@ func updateSystemVariables(cfg mysql.ListenerConfig) error {
137137
if err != nil {
138138
return err
139139
}
140-
print(port)
141140
portInt, err := strconv.ParseInt(port, 10, 64)
142141
if err != nil {
143142
return err
144143
}
145-
if portInt == 0 {
146-
}
144+
// TODO: add the rest of the config variables
147145
err = sql.SystemVariables.AssignValues(map[string]interface{}{
148146
"port": portInt,
149147
"hostname": hostname,
150-
// TODO: the rest
148+
// TODO: this causes an error because max_connections is 0?
151149
//"max_connections": cfg.MaxConns,
152150
})
153151
if err != nil {

0 commit comments

Comments
 (0)