Skip to content

Commit 0f238f3

Browse files
author
James Cor
committed
errors?
1 parent 6d30354 commit 0f238f3

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

memory/database.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -589,12 +589,6 @@ func (d *Database) AllViews(ctx *sql.Context) ([]sql.ViewDefinition, error) {
589589
return views, nil
590590
}
591591

592-
// GetViewDefinitionAsOf implements the interface sql.ViewDatabase.
593-
func (d *Database) GetViewDefinitionAsOf(ctx *sql.Context, viewName string, asOf interface{}) (sql.ViewDefinition, bool, error) {
594-
viewDef, ok := d.views[strings.ToLower(viewName)]
595-
return viewDef, ok, nil
596-
}
597-
598592
// GetViewDefinition implements the interface sql.ViewDatabase.
599593
func (d *Database) GetViewDefinition(ctx *sql.Context, viewName string) (sql.ViewDefinition, bool, error) {
600594
viewDef, ok := d.views[strings.ToLower(viewName)]

sql/mysql_db/privileged_database_provider.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ func (pdb PrivilegedDatabase) GetViewDefinitionAsOf(ctx *sql.Context, viewName s
401401
if db, ok := pdb.db.(sql.VersionedViewDatabase); ok {
402402
return db.GetViewDefinitionAsOf(ctx, viewName, asOf)
403403
}
404-
return sql.ViewDefinition{}, false, sql.ErrAsOfNotSupported.New(pdb.db.Name())
404+
return sql.ViewDefinition{}, false, nil
405405
}
406406

407407
// GetViewDefinition implements sql.ViewDatabase

sql/planbuilder/from.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -862,7 +862,7 @@ func (b *Builder) resolveView(name string, database sql.Database, asOf interface
862862
if asOf != nil {
863863
vdb, vok := database.(sql.VersionedViewDatabase)
864864
if !vok {
865-
b.handleErr(sql.ErrAsOfNotSupported.New(database.Name()))
865+
return nil
866866
}
867867
viewDef, vdok, err := vdb.GetViewDefinitionAsOf(b.ctx, name, asOf)
868868
if err != nil {

0 commit comments

Comments
 (0)