PR feedback

Author: zachmu

enginetest/enginetests.go

@@ -5480,9 +5480,7 @@ func TestAlterTable(t *testing.T, harness Harness) {
 			},
 		}, checks)
 	})
-}
 
-func TestAlterTableScripts(t *testing.T, harness Harness) {
 	for _, script := range queries.AlterTableScripts {
 		TestScript(t, harness, script)
 	}

enginetest/memory_engine_test.go

@@ -838,10 +838,6 @@ func TestAlterTable(t *testing.T) {
 	enginetest.TestAlterTable(t, enginetest.NewDefaultMemoryHarness())
 }
 
-func TestAlterTableScripts(t *testing.T) {
-	enginetest.TestAlterTableScripts(t, enginetest.NewDefaultMemoryHarness())
-}
-
 func TestDateParse(t *testing.T) {
 	enginetest.TestDateParse(t, enginetest.NewDefaultMemoryHarness())
 }

enginetest/queries/alter_table_queries.go

@@ -23,10 +23,8 @@ import (
 
 var AlterTableScripts = []ScriptTest{
 	{
+		// This script relies on setup.Pk_tablesData
 		Name: "Error queries",
-		SetUpScript: []string{
-			"create table one_pk_two_idx (pk bigint primary key, v1 bigint, v2 bigint, index idx1 (v1), index idx2 (v2));",
-		},
 		Assertions: []ScriptTestAssertion{
 			{
 				Query:       "ALTER TABLE one_pk_two_idx MODIFY COLUMN v1 BIGINT DEFAULT (pk) AFTER v3",