Skip to content

Commit 12324f5

Browse files
elianddbclaude
andcommitted
Clean up inaccurate comments and remove duplicate tests
- Remove misleading comment about customer complaints regarding <unknown> - Remove duplicate test for long invalid sequence (999897969594939291) - Correct test descriptions to focus on charset validation functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 2b35ad2 commit 12324f5

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

enginetest/queries/script_queries.go

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7162,10 +7162,6 @@ where
71627162
{types.OkResult{RowsAffected: 1}},
71637163
},
71647164
},
7165-
{
7166-
Query: "insert into t(c) values (X'999897969594939291');",
7167-
ExpectedErrStr: "Incorrect string value: '\\x99\\x98\\x97\\x96\\x95\\x94...' for column 'c' at row 1",
7168-
},
71697165
},
71707166
},
71717167
{
@@ -7238,13 +7234,12 @@ where
72387234
"create table products (id int primary key, name text character set utf8mb4);",
72397235
},
72407236
Assertions: []ScriptTestAssertion{
7241-
// Customer's problem: inserting latin1-encoded "DoltLab®" into utf8mb4 column
7242-
// Before fix: error showed "<unknown>" instead of column name
7237+
// Test charset validation with invalid UTF-8 data
72437238
{
7244-
Query: "insert into products values (1, UNHEX('446F6C744C6162AE'));", // "DoltLab®" as latin1 bytes
7239+
Query: "insert into products values (1, UNHEX('446F6C744C6162AE'));", // "DoltLab" + invalid byte 0xAE
72457240
ExpectedErrStr: "Incorrect string value: '\\xAE' for column 'name' at row 1",
72467241
},
7247-
// Customer's solution: use non-strict mode to clean up data
7242+
// Test non-strict mode truncation behavior
72487243
{
72497244
Query: "set sql_mode = '';",
72507245
Expected: []sql.Row{{types.OkResult{RowsAffected: 0}}},

0 commit comments

Comments
 (0)