fix format errs and redundant edits

Author: elianddb

enginetest/queries/script_queries.go

@@ -8720,8 +8720,6 @@ where
 		},
 	},
 	{
-		// This tests STRICT_ALL_TABLES mode specifically
-		Skip:    false,
 		Name:    "enums with zero strict all tables",
 		Dialect: "mysql",
 		SetUpScript: []string{

sql/expression/enum.go

@@ -14,8 +14,6 @@
 package expression
 
 import (
-	"fmt"
-
 	"github.com/dolthub/go-mysql-server/sql"
 	"github.com/dolthub/go-mysql-server/sql/types"
 )
@@ -82,7 +80,7 @@ func (e *EnumToString) Eval(ctx *sql.Context, row sql.Row) (interface{}, error)
 	case string:
 		str = v
 	default:
-		return nil, sql.ErrInvalidType.New(fmt.Sprintf("%T", val))
+		return nil, sql.ErrInvalidType.New(types.Text.String())
 	}
 	return str, nil
 }

sql/planbuilder/ddl.go

@@ -1299,17 +1299,14 @@ func validateDefaultExprs(col *sql.Column) error {
 		return nil
 	}
 
-	// Validate datetime/timestamp precision
-	if types.IsDatetimeType(col.Type) || types.IsTimestampType(col.Type) {
-		var colPrec int
-		if dt, ok := col.Type.(sql.DatetimeType); ok {
-			colPrec = dt.Precision()
-		}
-		if isValid, err := validatePrec(col.Default.Expr, colPrec); err != nil {
-			return err
-		} else if !isValid {
-			return sql.ErrInvalidColumnDefaultValue.New(col.Name)
-		}
+	var colPrec int
+	if dt, ok := col.Type.(sql.DatetimeType); ok {
+		colPrec = dt.Precision()
+	}
+	if isValid, err := validatePrec(col.Default.Expr, colPrec); err != nil {
+		return err
+	} else if !isValid {
+		return sql.ErrInvalidColumnDefaultValue.New(col.Name)
 	}
 
 	return nil