catch duplicates

James Cor · James Cor · commit 14a7c3c42a21 · 2024-11-08T11:35:59.000-08:00
diff --git a/sql/planbuilder/ddl.go b/sql/planbuilder/ddl.go
@@ -452,11 +452,20 @@ func (b *Builder) buildCreateTableLike(inScope *scope, ct *ast.DDL) *scope {
 		}
 	}
 
+	var hasSkippedCols bool
 	for _, col := range pkSch.Schema {
+		name := strings.ToLower(col.Name)
+		if _, ok := newSchMap[name]; ok {
+			// TODO: throw warning
+			hasSkippedCols = true
+			continue
+		}
 		newSch = append(newSch, col)
 	}
-	for _, pkOrd := range pkSch.PkOrdinals {
-		pkOrdinals = append(pkOrdinals, len(newSch)+pkOrd)
+	if !hasSkippedCols {
+		for _, pkOrd := range pkSch.PkOrdinals {
+			pkOrdinals = append(pkOrdinals, len(newSch)+pkOrd)
+		}
 	}
 
 	pkSchema := sql.NewPrimaryKeySchema(newSch, pkOrdinals...)

Original file line number	Diff line number	Diff line change
`@@ -452,11 +452,20 @@ func (b Builder) buildCreateTableLike(inScope scope, ct ast.DDL) scope {`
`452`	`452`	`}`
`453`	`453`	`}`
`454`	`454`
	`455`	`+ var hasSkippedCols bool`
`455`	`456`	`for _, col := range pkSch.Schema {`
	`457`	`+ name := strings.ToLower(col.Name)`
	`458`	`+ if _, ok := newSchMap[name]; ok {`
	`459`	`+ // TODO: throw warning`
	`460`	`+ hasSkippedCols = true`
	`461`	`+ continue`
	`462`	`+ }`
`456`	`463`	`newSch = append(newSch, col)`
`457`	`464`	`}`
`458`		`- for _, pkOrd := range pkSch.PkOrdinals {`
`459`		`- pkOrdinals = append(pkOrdinals, len(newSch)+pkOrd)`
	`465`	`+ if !hasSkippedCols {`
	`466`	`+ for _, pkOrd := range pkSch.PkOrdinals {`
	`467`	`+ pkOrdinals = append(pkOrdinals, len(newSch)+pkOrd)`
	`468`	`+ }`
`460`	`469`	`}`
`461`	`470`
`462`	`471`	`pkSchema := sql.NewPrimaryKeySchema(newSch, pkOrdinals...)`