Skip to content

Commit 1615504

Browse files
elianddbclaude
andcommitted
dolthub/dolt#9481 - Fix FLOAT/DOUBLE auto_increment test expectations
- Unskip float and double auto_increment tests - Update test expectations to match MySQL 8.0.42 behavior - FLOAT and DOUBLE are allowed with AUTO_INCREMENT in MySQL - Fix collation expectations in SHOW CREATE TABLE tests - All tests now pass confirming GMS matches MySQL behavior 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent a7be6c3 commit 1615504

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

enginetest/queries/script_queries.go

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10060,28 +10060,34 @@ where
1006010060

1006110061
// Float Tests
1006210062
{
10063-
Skip: true,
1006410063
Name: "float with auto_increment",
1006510064
Dialect: "mysql",
1006610065
SetUpScript: []string{},
1006710066
Assertions: []ScriptTestAssertion{
1006810067
{
10069-
Query: "create table bad (f float primary key auto_increment);",
10070-
ExpectedErrStr: "Incorrect column specifier for column 'f'",
10068+
Query: "create table float_tbl (f float primary key auto_increment);",
10069+
Expected: []sql.Row{{types.OkResult{}}},
10070+
},
10071+
{
10072+
Query: "show create table float_tbl;",
10073+
Expected: []sql.Row{{"float_tbl", "CREATE TABLE `float_tbl` (\n `f` float NOT NULL AUTO_INCREMENT,\n PRIMARY KEY (`f`)\n) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_bin"}},
1007110074
},
1007210075
},
1007310076
},
1007410077

1007510078
// Double Tests
1007610079
{
10077-
Skip: true,
1007810080
Name: "double with auto_increment",
1007910081
Dialect: "mysql",
1008010082
SetUpScript: []string{},
1008110083
Assertions: []ScriptTestAssertion{
1008210084
{
10083-
Query: "create table bad (d double primary key auto_increment);",
10084-
ExpectedErrStr: "Incorrect column specifier for column 'vc'",
10085+
Query: "create table double_tbl (d double primary key auto_increment);",
10086+
Expected: []sql.Row{{types.OkResult{}}},
10087+
},
10088+
{
10089+
Query: "show create table double_tbl;",
10090+
Expected: []sql.Row{{"double_tbl", "CREATE TABLE `double_tbl` (\n `d` double NOT NULL AUTO_INCREMENT,\n PRIMARY KEY (`d`)\n) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_bin"}},
1008510091
},
1008610092
},
1008710093
},

0 commit comments

Comments
 (0)