Propogate context in StringType::Compare

nicktobey · nicktobey · commit 1d90344c4c30 · 2025-03-31T23:47:50.000-07:00
diff --git a/sql/types/strings.go b/sql/types/strings.go
@@ -244,14 +244,11 @@ func (t StringType) Length() int64 {
 }
 
 // Compare implements Type interface.
-func (t StringType) Compare(s context.Context, a interface{}, b interface{}) (int, error) {
+func (t StringType) Compare(ctx context.Context, a interface{}, b interface{}) (int, error) {
 	if hasNulls, res := CompareNulls(a, b); hasNulls {
 		return res, nil
 	}
 
-	// TODO: Add context parameter to Compare
-	ctx := context.Background()
-
 	var as string
 	var bs string
 	var ok bool

Original file line number	Diff line number	Diff line change
`@@ -244,14 +244,11 @@ func (t StringType) Length() int64 {`
`244`	`244`	`}`
`245`	`245`
`246`	`246`	`// Compare implements Type interface.`
`247`		`-func (t StringType) Compare(s context.Context, a interface{}, b interface{}) (int, error) {`
	`247`	`+func (t StringType) Compare(ctx context.Context, a interface{}, b interface{}) (int, error) {`
`248`	`248`	`if hasNulls, res := CompareNulls(a, b); hasNulls {`
`249`	`249`	`return res, nil`
`250`	`250`	`}`
`251`	`251`
`252`		`- // TODO: Add context parameter to Compare`
`253`		`- ctx := context.Background()`
`254`		`-`
`255`	`252`	`var as string`
`256`	`253`	`var bs string`
`257`	`254`	`var ok bool`