Merge pull request #3214 from dolthub/angela/pipes_as_concat

Implement `PIPES_AS_CONCAT` mode

Author: angelamayxie

enginetest/queries/script_queries.go

@@ -12140,6 +12140,108 @@ select * from t1 except (
 			},
 		},
 	},
+	{
+		Name:    "pipes as concat mode",
+		Dialect: "mysql",
+		SetUpScript: []string{
+			"create table names(first_name varchar(20), last_name varchar(20))",
+			"insert into names values ('john', 'smith'), ('bob','burger')",
+		},
+		Assertions: []ScriptTestAssertion{
+			{
+				Query:    "select true || false",
+				Expected: []sql.Row{{true}},
+			},
+			{
+				Query:    "select '0' || '0'",
+				Expected: []sql.Row{{false}},
+			},
+			{
+				Query:    "select 'Hello' || ' ' || 'World'",
+				Expected: []sql.Row{{false}},
+			},
+			{
+				Query:    "select 1 || 0",
+				Expected: []sql.Row{{true}},
+			},
+			{
+				Query:    "select first_name || ' ' || last_name as full_name from names order by full_name",
+				Expected: []sql.Row{{false}, {false}},
+			},
+			{
+				Query:    "select 1 + 2 || 3 + 4",
+				Expected: []sql.Row{{true}},
+			},
+			{
+				Query:    "select true || 1 || 'abc'",
+				Expected: []sql.Row{{true}},
+			},
+			{
+				Query:    "select (1 || 2) || (3 || 4)",
+				Expected: []sql.Row{{true}},
+			},
+			{
+				Query:    "select (1 + 2) || (3 + 4)",
+				Expected: []sql.Row{{true}},
+			},
+			{
+				Query:    "select ((1 || 2) || 3) || 4",
+				Expected: []sql.Row{{true}},
+			},
+			{
+				Query:    "select ((1 + 2) || 3) + 4",
+				Expected: []sql.Row{{5}},
+			},
+			{
+				Query:    "SET SESSION sql_mode = CONCAT(@@SESSION.sql_mode, ',PIPES_AS_CONCAT');",
+				Expected: []sql.Row{{types.NewOkResult(0)}},
+			},
+			{
+				Query:    "select true || false",
+				Expected: []sql.Row{{"10"}},
+			},
+			{
+				Query:    "select '0' || '0'",
+				Expected: []sql.Row{{"00"}},
+			},
+			{
+				Query:    "select 'Hello' || ' ' || 'World'",
+				Expected: []sql.Row{{"Hello World"}},
+			},
+			{
+				Query:    "select 1 || 0",
+				Expected: []sql.Row{{"10"}},
+			},
+			{
+				Query:    "select first_name || ' ' || last_name as full_name from names order by full_name",
+				Expected: []sql.Row{{"bob burger"}, {"john smith"}},
+			},
+			{
+				Query:    "select 1 + 2 || 3 + 4",
+				Expected: []sql.Row{{float64(28)}},
+			},
+			{
+				Query:    "select true || 1 || 'abc'",
+				Expected: []sql.Row{{"11abc"}},
+			},
+			{
+				Query:    "select (1 || 2) || (3 || 4)",
+				Expected: []sql.Row{{"1234"}},
+			},
+			{
+				Query:    "select (1 + 2) || (3 + 4)",
+				Expected: []sql.Row{{"37"}},
+			},
+			{
+				Query:    "select ((1 || 2) || 3) || 4",
+				Expected: []sql.Row{{"1234"}},
+			},
+			{
+				Query:    "select ((1 + 2) || 3) + 4",
+				Expected: []sql.Row{{float64(37)}},
+			},
+		},
+	},
 }
 
 var SpatialScriptTests = []ScriptTest{

go.mod

@@ -6,7 +6,7 @@ require (
 	github.com/dolthub/go-icu-regex v0.0.0-20250820171420-f2b78f56ce9f
 	github.com/dolthub/jsonpath v0.0.2-0.20240227200619-19675ab05c71
 	github.com/dolthub/sqllogictest/go v0.0.0-20201107003712-816f3ae12d81
-	github.com/dolthub/vitess v0.0.0-20250902225707-0159e964d73d
+	github.com/dolthub/vitess v0.0.0-20250915221346-753c44800850
 	github.com/go-sql-driver/mysql v1.9.3
 	github.com/gocraft/dbr/v2 v2.7.2
 	github.com/google/uuid v1.3.0

go.sum

@@ -20,6 +20,8 @@ github.com/dolthub/sqllogictest/go v0.0.0-20201107003712-816f3ae12d81 h1:7/v8q9X
 github.com/dolthub/sqllogictest/go v0.0.0-20201107003712-816f3ae12d81/go.mod h1:siLfyv2c92W1eN/R4QqG/+RjjX5W2+gCTRjZxBjI3TY=
 github.com/dolthub/vitess v0.0.0-20250902225707-0159e964d73d h1:oTWJxjzRmuHKuICUunCUwNuonubkXwOqPa5hXX3dXBo=
 github.com/dolthub/vitess v0.0.0-20250902225707-0159e964d73d/go.mod h1:tV3BrIVyDWVkkYy8dKt2o6hjJ89cHb5opY5FpCyhncQ=
+github.com/dolthub/vitess v0.0.0-20250915221346-753c44800850 h1:QXkIRTquxaGUgKVHnKZxU+ikARdszUUDU6C9B/76+a0=
+github.com/dolthub/vitess v0.0.0-20250915221346-753c44800850/go.mod h1:tV3BrIVyDWVkkYy8dKt2o6hjJ89cHb5opY5FpCyhncQ=
 github.com/go-sql-driver/mysql v1.4.1/go.mod h1:zAC/RDZ24gD3HViQzih4MyKcchzm+sOG5ZlKdlhCg5w=
 github.com/go-sql-driver/mysql v1.5.0/go.mod h1:DCzpHaOWr8IXmIStZouvnhqoel9Qv2LBy8hT2VhHyBg=
 github.com/go-sql-driver/mysql v1.6.0/go.mod h1:DCzpHaOWr8IXmIStZouvnhqoel9Qv2LBy8hT2VhHyBg=

sql/sql_mode.go

@@ -30,6 +30,7 @@ const (
 	NoAutoValueOnZero    = "NO_AUTO_VALUE_ON_ZERO"
 	NoEngineSubstitution = "NO_ENGINE_SUBSTITUTION"
 	StrictTransTables    = "STRICT_TRANS_TABLES"
+	PipesAsConcat        = "PIPES_AS_CONCAT"
 	DefaultSqlMode       = "NO_ENGINE_SUBSTITUTION,ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES"
 )
 
@@ -98,6 +99,11 @@ func (s *SqlMode) AnsiQuotes() bool {
 	return s.ModeEnabled(ANSIQuotes) || s.ModeEnabled(ANSI)
 }
 
+// PipesAsConcat returns true if PIPES_AS_CONCAT SQL mode is enabled.
+func (s *SqlMode) PipesAsConcat() bool {
+	return s.ModeEnabled(PipesAsConcat)
+}
+
 // ModeEnabled returns true if |mode| was explicitly specified in the SQL_MODE string that was used to
 // create this SqlMode instance. Note this function does not support expanding compound modes into the
 // individual modes they contain (e.g. if "ANSI" is the SQL_MODE string, then this function will not
@@ -111,7 +117,8 @@ func (s *SqlMode) ModeEnabled(mode string) bool {
 // ParserOptions returns a ParserOptions struct, with options set based on what SQL modes are enabled.
 func (s *SqlMode) ParserOptions() sqlparser.ParserOptions {
 	return sqlparser.ParserOptions{
-		AnsiQuotes: s.AnsiQuotes(),
+		AnsiQuotes:    s.AnsiQuotes(),
+		PipesAsConcat: s.PipesAsConcat(),
 	}
 }
 

sql/sql_mode_test.go

@@ -30,6 +30,8 @@ func TestSqlMode(t *testing.T) {
 	assert.False(t, sqlMode.ModeEnabled("fake_mode"))
 	assert.True(t, sqlMode.ParserOptions().AnsiQuotes)
 	assert.Equal(t, "ANSI,ONLY_FULL_GROUP_BY", sqlMode.String())
+	assert.False(t, sqlMode.PipesAsConcat())
+	assert.False(t, sqlMode.ModeEnabled("pipes_as_concat"))
 
 	// Test a mixed case SQL_MODE string where only ANSI_QUOTES is enabled
 	sqlMode = NewSqlModeFromString("AnSi_quotEs")
@@ -39,12 +41,16 @@ func TestSqlMode(t *testing.T) {
 	assert.False(t, sqlMode.ModeEnabled("fake_mode"))
 	assert.True(t, sqlMode.ParserOptions().AnsiQuotes)
 	assert.Equal(t, "ANSI_QUOTES", sqlMode.String())
+	assert.False(t, sqlMode.PipesAsConcat())
+	assert.False(t, sqlMode.ModeEnabled("pipes_as_concat"))
 
-	// Test when SQL_MODE does not include ANSI_QUOTES
-	sqlMode = NewSqlModeFromString("ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES")
+	// Test when SQL_MODE does not include ANSI_QUOTES, includes PIPES_AS_CONCAT
+	sqlMode = NewSqlModeFromString("ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,PIPES_AS_CONCAT")
 	assert.False(t, sqlMode.AnsiQuotes())
 	assert.True(t, sqlMode.ModeEnabled("STRICT_TRANS_TABLES"))
 	assert.False(t, sqlMode.ModeEnabled("ansi_quotes"))
 	assert.False(t, sqlMode.ParserOptions().AnsiQuotes)
-	assert.Equal(t, "ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES", sqlMode.String())
+	assert.True(t, sqlMode.PipesAsConcat())
+	assert.True(t, sqlMode.ModeEnabled("pipes_as_concat"))
+	assert.Equal(t, "ONLY_FULL_GROUP_BY,PIPES_AS_CONCAT,STRICT_TRANS_TABLES", sqlMode.String())
 }