Merge pull request #3101 from dolthub/elianddb/9472-fix-set-column-foreign-key-constraints

dolthub/dolt#9472 - Fix SET column foreign key constraintsfix specific errs

Author: elianddb

enginetest/queries/script_queries.go

@@ -10131,8 +10131,8 @@ where
 				},
 			},
 			{
-				Query:       "insert into t2 values ('A,B,c');",
-				ExpectedErr: sql.ErrInvalidSetValue,
+				Query:          "insert into t2 values ('A,B,c');",
+				ExpectedErrStr: "Data truncated for column 's' at row 1",
 			},
 			{
 				Query:    "select * from t2",
@@ -10145,7 +10145,6 @@ where
 		},
 	},
 	{
-		Skip:    true,
 		Name:    "set with foreign keys",
 		Dialect: "mysql",
 		SetUpScript: []string{
@@ -10325,7 +10324,6 @@ where
 		},
 	},
 	{
-		Skip:    true,
 		Name:    "set with foreign keys and cascade",
 		Dialect: "mysql",
 		SetUpScript: []string{

sql/plan/alter_foreign_key.go

@@ -663,6 +663,9 @@ func foreignKeyComparableTypes(ctx *sql.Context, type1 sql.Type, type2 sql.Type)
 				// MySQL allows decimal foreign keys with different precision/scale
 				// The foreign key constraint validation will handle the actual value comparison
 				return true
+			case sqltypes.Set:
+				// MySQL allows set foreign keys to match based on underlying numeric values.
+				return true
 			default:
 				return false
 			}

sql/plan/foreign_key_editor.go

@@ -509,6 +509,11 @@ func (reference *ForeignKeyReferenceHandler) CheckReference(ctx *sql.Context, ro
 
 	_, err = rowIter.Next(ctx)
 	if err != nil && err != io.EOF {
+		// For SET types, conversion failures during foreign key validation should be treated as foreign key violations
+		if sql.ErrConvertingToSet.Is(err) || sql.ErrInvalidSetValue.Is(err) {
+			return sql.ErrForeignKeyChildViolation.New(reference.ForeignKey.Name, reference.ForeignKey.Table,
+				reference.ForeignKey.ParentTable, reference.RowMapper.GetKeyString(row))
+		}
 		return err
 	}
 	if err == nil {

sql/rowexec/insert.go

@@ -153,6 +153,8 @@ func (i *insertIter) Next(ctx *sql.Context) (returnRow sql.Row, returnErr error)
 						cErr = sql.ErrNotMatchingSRIDWithColName.New(col.Name, cErr)
 					} else if types.ErrConvertingToEnum.Is(cErr) {
 						cErr = types.ErrDataTruncatedForColumnAtRow.New(col.Name, i.rowNumber)
+					} else if sql.ErrInvalidSetValue.Is(cErr) || sql.ErrConvertingToSet.Is(cErr) {
+						cErr = types.ErrDataTruncatedForColumnAtRow.New(col.Name, i.rowNumber)
 					}
 					return nil, sql.NewWrappedInsertError(origRow, cErr)
 				}