Merge pull request #2981 from dolthub/nicktobey/json_test

Unwrap wrapper values used in JSON aggregation functions, and un-skip accidentally-skipped tests for this behavior.

Author: nicktobey

enginetest/enginetests.go

@@ -5156,12 +5156,14 @@ func TestNullRanges(t *testing.T, harness Harness) {
 func TestJsonScripts(t *testing.T, harness Harness, skippedTests []string) {
 	harness.Setup(setup.MydbData, setup.BlobData)
 	for _, script := range queries.JsonScripts {
-		for _, skippedTest := range skippedTests {
-			if strings.Contains(script.Name, skippedTest) {
-				t.Skip()
+		t.Run(script.Name, func(t *testing.T) {
+			for _, skippedTest := range skippedTests {
+				if strings.Contains(script.Name, skippedTest) {
+					t.Skip()
+				}
 			}
-		}
-		TestScript(t, harness, script)
+			TestScript(t, harness, script)
+		})
 	}
 }
 

sql/expression/function/aggregation/json_agg.go

@@ -157,7 +157,11 @@ func (j *jsonObjectBuffer) Update(ctx *sql.Context, row sql.Row) error {
 		return err
 	}
 
-	// unwrap JSON values
+	// unwrap wrapper values
+	val, err = sql.UnwrapAny(ctx, val)
+	if err != nil {
+		return err
+	}
 	if js, ok := val.(sql.JSONWrapper); ok {
 		val, err = js.ToInterface()
 		if err != nil {
@@ -166,11 +170,12 @@ func (j *jsonObjectBuffer) Update(ctx *sql.Context, row sql.Row) error {
 	}
 
 	// Update the map.
-	keyAsString, _, err := types.LongText.Convert(ctx, key)
+	convertedKey, _, err := types.LongText.Convert(ctx, key)
 	if err != nil {
 		return nil
 	}
-	j.vals[keyAsString.(string)] = val
+	keyAsString, _, err := sql.Unwrap[string](ctx, convertedKey)
+	j.vals[keyAsString] = val
 
 	return nil
 }

sql/expression/function/aggregation/unary_agg_buffers.go

@@ -646,7 +646,11 @@ func (j *jsonArrayBuffer) Update(ctx *sql.Context, row sql.Row) error {
 		return err
 	}
 
-	// unwrap JSON values
+	// unwrap wrapper values
+	v, err = sql.UnwrapAny(ctx, v)
+	if err != nil {
+		return err
+	}
 	if js, ok := v.(sql.JSONWrapper); ok {
 		v, err = js.ToInterface()
 		if err != nil {

sql/expression/function/aggregation/window_functions.go

@@ -1049,7 +1049,11 @@ func (a *WindowedJSONArrayAgg) aggregateVals(ctx *sql.Context, interval sql.Wind
 			return nil, err
 		}
 
-		// unwrap JSON values
+		// unwrap wrapper values
+		v, err = sql.UnwrapAny(ctx, v)
+		if err != nil {
+			return nil, err
+		}
 		if js, ok := v.(sql.JSONWrapper); ok {
 			v, err = js.ToInterface()
 			if err != nil {
@@ -1136,7 +1140,11 @@ func (a *WindowedJSONObjectAgg) aggregateVals(ctx *sql.Context, interval sql.Win
 			return nil, err
 		}
 
-		// unwrap JSON values
+		// unwrap wrapper values
+		val, err = sql.UnwrapAny(ctx, val)
+		if err != nil {
+			return nil, err
+		}
 		if js, ok := val.(sql.JSONWrapper); ok {
 			val, err = js.ToInterface()
 			if err != nil {