Skip to content

Commit 2a94ec7

Browse files
committed
Remove out of date TODOs
1 parent 6df0972 commit 2a94ec7

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

sql/plan/insert.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,12 +130,7 @@ func (ii *InsertInto) Schema() sql.Schema {
130130

131131
// Postgres allows the returned values of the insert statement to be controlled, so if returning expressions
132132
// were specified, then we return a different schema.
133-
// TODO: does anything else depend on the schema returned by insert statements? triggers?
134-
// TODO: Do we need to check for the expressions being fully resolved? (probably!)
135133
if ii.Returning != nil {
136-
// TODO: If we don't return the destination schema anymore... does that mess up other things, like trigger processing?
137-
// TODO: we need to look at the expressions in the returning clause
138-
139134
// We know that returning exprs are resolved here, because you can't call Schema() safely until Resolved() is true.
140135
returningSchema := sql.Schema{}
141136
for _, expr := range ii.Returning {

0 commit comments

Comments
 (0)