Get field string concat (#2732)

* GetField.String avoids Sprintf

* more avoid sprintf

* fix typo

Author: max-hoffman

sql/analyzer/fix_exec_indexes.go

@@ -170,7 +170,7 @@ func (s *idxScope) addSchema(sch sql.Schema) {
 		if c.Source == "" {
 			s.columns = append(s.columns, c.Name)
 		} else {
-			s.columns = append(s.columns, fmt.Sprintf("%s.%s", c.Source, c.Name))
+			s.columns = append(s.columns, c.Source+"."+c.Name)
 		}
 	}
 }

sql/expression/get_field.go

@@ -163,11 +163,11 @@ func (p *GetField) WithChildren(children ...sql.Expression) (sql.Expression, err
 func (p *GetField) String() string {
 	if p.table == "" {
 		if p.backTickNames {
-			return fmt.Sprintf("`%s`", p.name)
+			return "`" + p.name + "`"
 		}
 		return p.name
 	}
-	return fmt.Sprintf("%s.%s", p.table, p.name)
+	return p.table + "." + p.name
 }
 
 func (p *GetField) DebugString() string {

sql/planbuilder/scope.go

@@ -15,7 +15,6 @@
 package planbuilder
 
 import (
-	"fmt"
 	"strings"
 
 	ast "github.com/dolthub/vitess/go/vt/sqlparser"
@@ -638,6 +637,6 @@ func (c scopeColumn) String() string {
 	if c.table == "" {
 		return c.col
 	} else {
-		return fmt.Sprintf("%s.%s", c.table, c.col)
+		return c.table + "." + c.col
 	}
 }