Skip to content

Commit 2f79d20

Browse files
committed
remove memory engine test from commit
1 parent 7765d4e commit 2f79d20

File tree

1 file changed

+13
-65
lines changed

1 file changed

+13
-65
lines changed

enginetest/memory_engine_test.go

Lines changed: 13 additions & 65 deletions
Original file line numberDiff line numberDiff line change
@@ -200,74 +200,23 @@ func TestSingleQueryPrepared(t *testing.T) {
200200

201201
// Convenience test for debugging a single query. Unskip and set to the desired query.
202202
func TestSingleScript(t *testing.T) {
203-
// t.Skip()
203+
t.Skip()
204204
var scripts = []queries.ScriptTest{
205205
{
206-
// https://github.com/dolthub/dolt/issues/9895
207-
Name: "insert returning works with after triggers",
208-
SetUpScript: []string{
209-
"create table parent (id int not null auto_increment, primary key (id))",
210-
"create table child(parent_id int not null, version_id int not null auto_increment, primary key (version_id))",
211-
"insert into parent () values ()",
212-
"create trigger trg_child_after_insert after insert on child for each row update parent set id = (id + 1) where id = NEW.parent_id",
213-
},
206+
Name: "AS OF propagates to nested CALLs",
207+
SetUpScript: []string{},
214208
Assertions: []queries.ScriptTestAssertion{
215209
{
216-
Query: "insert into child (parent_id) values (1) returning version_id",
217-
Expected: []sql.Row{{1}},
218-
},
219-
{
220-
Query: "select * from parent",
221-
Expected: []sql.Row{{2}},
222-
},
223-
{
224-
Query: "insert into child (parent_id) values (2) returning version_id",
225-
Expected: []sql.Row{{2}},
226-
},
227-
{
228-
Query: "select * from parent",
229-
Expected: []sql.Row{{3}},
230-
},
231-
{
232-
// https://github.com/dolthub/dolt/issues/9907
233-
Skip: true,
234-
Query: "insert into child (parent_id) values ((select id from parent limit 1)) returning parent_id, version_id",
235-
// TODO: update to actual error
236-
ExpectedErr: nil,
237-
},
238-
},
239-
},
240-
{
241-
Name: "insert returning works with before triggers",
242-
SetUpScript: []string{
243-
"create table parent (id int not null auto_increment, primary key (id))",
244-
"create table child(parent_id int not null, version_id int not null auto_increment, primary key (version_id))",
245-
"insert into parent () values ()",
246-
"create trigger trg_child_before_insert before insert on child for each row update parent set id = (id + 1) where id = NEW.parent_id",
247-
},
248-
Assertions: []queries.ScriptTestAssertion{
249-
{
250-
Query: "insert into child (parent_id) values (1) returning version_id",
251-
Expected: []sql.Row{{1}},
252-
},
253-
{
254-
Query: "select * from parent",
255-
Expected: []sql.Row{{2}},
256-
},
257-
{
258-
Query: "insert into child (parent_id) values (2) returning version_id",
259-
Expected: []sql.Row{{2}},
260-
},
261-
{
262-
Query: "select * from parent",
263-
Expected: []sql.Row{{3}},
210+
Query: "create procedure create_proc() create table t (i int primary key, j int);",
211+
Expected: []sql.Row{
212+
{types.NewOkResult(0)},
213+
},
264214
},
265215
{
266-
//https://github.com/dolthub/dolt/issues/9907
267-
Skip: true,
268-
Query: "insert into child (parent_id) values ((select id from parent limit 1)) returning version_id",
269-
// TODO: update to actual error
270-
ExpectedErr: nil,
216+
Query: "call create_proc()",
217+
Expected: []sql.Row{
218+
{types.NewOkResult(0)},
219+
},
271220
},
272221
},
273222
},
@@ -276,14 +225,13 @@ func TestSingleScript(t *testing.T) {
276225
for _, test := range scripts {
277226
harness := enginetest.NewMemoryHarness("", 1, testNumPartitions, true, nil)
278227
//harness.UseServer()
279-
// harness.Setup(append(setup.ComplexIndexSetup, setup.Pk_tablesData)...)
280228
engine, err := harness.NewEngine(t)
281229
if err != nil {
282230
panic(err)
283231
}
284232

285-
engine.EngineAnalyzer().Debug = true
286-
engine.EngineAnalyzer().Verbose = true
233+
//engine.EngineAnalyzer().Debug = true
234+
//engine.EngineAnalyzer().Verbose = true
287235

288236
enginetest.TestScriptWithEngine(t, engine, harness, test)
289237
}

0 commit comments

Comments
 (0)