clean up

James Cor · James Cor · commit 2fa06407bc5f · 2025-07-25T12:50:12.000-07:00
diff --git a/enginetest/evaluation.go b/enginetest/evaluation.go
@@ -145,7 +145,6 @@ func TestScriptWithEngine(t *testing.T, e QueryEngine, harness Harness, script q
 					TestQueryWithContext(t, ctx, e, harness, assertion.Query, expected, assertion.ExpectedColumns, assertion.Bindings, nil)
 				}
 
-				// TODO: remove these?
 				if assertion.ExpectedIndexes != nil && !IsServerEngine(e) {
 					evalIndexTest(t, harness, e, assertion.Query, assertion.ExpectedIndexes, assertion.Skip)
 				}
@@ -155,8 +154,7 @@ func TestScriptWithEngine(t *testing.T, e QueryEngine, harness Harness, script q
 
 				if assertion.ExpectedPlan != "" && !IsServerEngine(e) {
 					options := sql.DescribeOptions{
-						Estimates: true,
-						Analyze:   true,
+						Debug: true,
 					}
 					TestQueryPlanWithName(t, options.String(), harness, e, assertion.Query, assertion.ExpectedPlan, options)
 				}

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,6 @@ func TestScriptWithEngine(t *testing.T, e QueryEngine, harness Harness, script q`
`145`	`145`	`TestQueryWithContext(t, ctx, e, harness, assertion.Query, expected, assertion.ExpectedColumns, assertion.Bindings, nil)`
`146`	`146`	`}`
`147`	`147`
`148`		`- // TODO: remove these?`
`149`	`148`	`if assertion.ExpectedIndexes != nil && !IsServerEngine(e) {`
`150`	`149`	`evalIndexTest(t, harness, e, assertion.Query, assertion.ExpectedIndexes, assertion.Skip)`
`151`	`150`	`}`
`@@ -155,8 +154,7 @@ func TestScriptWithEngine(t *testing.T, e QueryEngine, harness Harness, script q`
`155`	`154`
`156`	`155`	`if assertion.ExpectedPlan != "" && !IsServerEngine(e) {`
`157`	`156`	`options := sql.DescribeOptions{`
`158`		`- Estimates: true,`
`159`		`- Analyze: true,`
	`157`	`+ Debug: true,`
`160`	`158`	`}`
`161`	`159`	`TestQueryPlanWithName(t, options.String(), harness, e, assertion.Query, assertion.ExpectedPlan, options)`
`162`	`160`	`}`