mcv checks before strconv

max-hoffman · max-hoffman · commit 364cbffd811f · 2025-03-04T13:47:19.000-08:00
diff --git a/sql/stats/iter.go b/sql/stats/iter.go
@@ -106,7 +106,9 @@ func (s *statsIter) bucketToRow(i int, bucket sql.HistogramBucket) (sql.Row, err
 	mcvs := make([]string, mcvCnt)
 
 	for i, mcv := range bucket.Mcvs() {
-		mcvs[i] = StringifyKey(mcv, s.types)
+		if len(mcv) > 0 {
+			mcvs[i] = StringifyKey(mcv, s.types)
+		}
 	}
 
 	return sql.Row{

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,9 @@ func (s *statsIter) bucketToRow(i int, bucket sql.HistogramBucket) (sql.Row, err`
`106`	`106`	`mcvs := make([]string, mcvCnt)`
`107`	`107`
`108`	`108`	`for i, mcv := range bucket.Mcvs() {`
`109`		`- mcvs[i] = StringifyKey(mcv, s.types)`
	`109`	`+ if len(mcv) > 0 {`
	`110`	`+ mcvs[i] = StringifyKey(mcv, s.types)`
	`111`	`+ }`
`110`	`112`	`}`
`111`	`113`
`112`	`114`	`return sql.Row{`