Skip to content

Commit 3bf72c6

Browse files
committed
Adding stack trace in error from panic handler
1 parent b5e2698 commit 3bf72c6

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

server/handler.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import (
2222
"io"
2323
"net"
2424
"regexp"
25+
"runtime/debug"
2526
"runtime/trace"
2627
"sync"
2728
"time"
@@ -619,7 +620,9 @@ func (h *Handler) resultForDefaultIter(ctx *sql.Context, c *mysql.Conn, schema s
619620
eg, ctx := ctx.NewErrgroup()
620621
pan2err := func(err *error) {
621622
if recoveredPanic := recover(); recoveredPanic != nil {
622-
*err = goerrors.Join(*err, fmt.Errorf("handler caught panic: %v", recoveredPanic))
623+
stack := debug.Stack()
624+
wrappedErr := fmt.Errorf("handler caught panic: %v\n%s", recoveredPanic, stack)
625+
*err = goerrors.Join(*err, wrappedErr)
623626
}
624627
}
625628
wg := sync.WaitGroup{}

0 commit comments

Comments
 (0)