Skip to content

Commit 3c1c073

Browse files
committed
Pass metrics server listener to DefaultProtocolListenerFunc for doltgres metrics
1 parent e44b780 commit 3c1c073

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

server/extension.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ func Intercept(h Interceptor) {
3535
func WithChain() Option {
3636
return func(e *sqle.Engine, sm *SessionManager, handler mysql.Handler) {
3737
f := DefaultProtocolListenerFunc
38-
DefaultProtocolListenerFunc = func(cfg mysql.ListenerConfig) (ProtocolListener, error) {
38+
DefaultProtocolListenerFunc = func(cfg mysql.ListenerConfig, sel ServerEventListener) (ProtocolListener, error) {
3939
cfg.Handler = buildChain(cfg.Handler)
40-
return f(cfg)
40+
return f(cfg, sel)
4141
}
4242
}
4343
}

server/server.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ type ProtocolListener interface {
3737
}
3838

3939
// ProtocolListenerFunc returns a ProtocolListener based on the configuration it was given.
40-
type ProtocolListenerFunc func(cfg mysql.ListenerConfig) (ProtocolListener, error)
40+
type ProtocolListenerFunc func(cfg mysql.ListenerConfig, sel ServerEventListener) (ProtocolListener, error)
4141

4242
// DefaultProtocolListenerFunc is the protocol listener, which defaults to Vitess' protocol listener. Changing
4343
// this function will change the protocol listener used when creating all servers. If multiple servers are needed
4444
// with different protocols, then create each server after changing this function. Servers retain the protocol that
4545
// they were created with.
46-
var DefaultProtocolListenerFunc ProtocolListenerFunc = func(cfg mysql.ListenerConfig) (ProtocolListener, error) {
46+
var DefaultProtocolListenerFunc ProtocolListenerFunc = func(cfg mysql.ListenerConfig, sel ServerEventListener) (ProtocolListener, error) {
4747
return mysql.NewListenerWithConfig(cfg)
4848
}
4949

@@ -75,7 +75,7 @@ func NewServer(cfg Config, e *sqle.Engine, sb SessionBuilder, listener ServerEve
7575
sel: listener,
7676
}
7777
//handler = NewHandler_(e, sm, cfg.ConnReadTimeout, cfg.DisableClientMultiStatements, cfg.MaxLoggedQueryLen, cfg.EncodeLoggedQuery, listener)
78-
return newServerFromHandler(cfg, e, sm, handler)
78+
return newServerFromHandler(cfg, e, sm, handler, listener)
7979
}
8080

8181
// HandlerWrapper provides a way for clients to wrap the mysql.Handler used by the server with a custom implementation
@@ -113,7 +113,7 @@ func NewServerWithHandler(
113113
return nil, err
114114
}
115115

116-
return newServerFromHandler(cfg, e, sm, handler)
116+
return newServerFromHandler(cfg, e, sm, handler, listener)
117117
}
118118

119119
func portInUse(hostPort string) bool {
@@ -126,7 +126,7 @@ func portInUse(hostPort string) bool {
126126
return false
127127
}
128128

129-
func newServerFromHandler(cfg Config, e *sqle.Engine, sm *SessionManager, handler mysql.Handler) (*Server, error) {
129+
func newServerFromHandler(cfg Config, e *sqle.Engine, sm *SessionManager, handler mysql.Handler, sel ServerEventListener) (*Server, error) {
130130
for _, option := range cfg.Options {
131131
option(e, sm, handler)
132132
}
@@ -169,7 +169,7 @@ func newServerFromHandler(cfg Config, e *sqle.Engine, sm *SessionManager, handle
169169
ConnReadBufferSize: mysql.DefaultConnBufferSize,
170170
AllowClearTextWithoutTLS: cfg.AllowClearTextWithoutTLS,
171171
}
172-
protocolListener, err := DefaultProtocolListenerFunc(listenerCfg)
172+
protocolListener, err := DefaultProtocolListenerFunc(listenerCfg, sel)
173173
if err != nil {
174174
return nil, err
175175
}

0 commit comments

Comments
 (0)