amend to use caller ctx

Author: elianddb

sql/analyzer/optimization_rules.go

@@ -237,37 +237,37 @@ func simplifyFilters(ctx *sql.Context, a *Analyzer, node sql.Node, scope *plan.S
 					expression.NewLessThanOrEqual(e.Val, e.Upper),
 				), transform.NewTree, nil
 			case *expression.Or:
-				if isTrue(e.LeftChild) {
+				if isTrue(ctx, e.LeftChild) {
 					return e.LeftChild, transform.NewTree, nil
 				}
 
-				if isTrue(e.RightChild) {
+				if isTrue(ctx, e.RightChild) {
 					return e.RightChild, transform.NewTree, nil
 				}
 
-				if isFalse(e.LeftChild) && types.IsBoolean(e.RightChild.Type()) {
+				if isFalse(ctx, e.LeftChild) && types.IsBoolean(e.RightChild.Type()) {
 					return e.RightChild, transform.NewTree, nil
 				}
 
-				if isFalse(e.RightChild) && types.IsBoolean(e.LeftChild.Type()) {
+				if isFalse(ctx, e.RightChild) && types.IsBoolean(e.LeftChild.Type()) {
 					return e.LeftChild, transform.NewTree, nil
 				}
 
 				return e, transform.SameTree, nil
 			case *expression.And:
-				if isFalse(e.LeftChild) {
+				if isFalse(ctx, e.LeftChild) {
 					return e.LeftChild, transform.NewTree, nil
 				}
 
-				if isFalse(e.RightChild) {
+				if isFalse(ctx, e.RightChild) {
 					return e.RightChild, transform.NewTree, nil
 				}
 
-				if isTrue(e.LeftChild) && types.IsBoolean(e.RightChild.Type()) {
+				if isTrue(ctx, e.LeftChild) && types.IsBoolean(e.RightChild.Type()) {
 					return e.RightChild, transform.NewTree, nil
 				}
 
-				if isTrue(e.RightChild) && types.IsBoolean(e.LeftChild.Type()) {
+				if isTrue(ctx, e.RightChild) && types.IsBoolean(e.LeftChild.Type()) {
 					return e.LeftChild, transform.NewTree, nil
 				}
 
@@ -360,12 +360,12 @@ func simplifyFilters(ctx *sql.Context, a *Analyzer, node sql.Node, scope *plan.S
 			return nil, transform.SameTree, err
 		}
 
-		if isFalse(e) {
+		if isFalse(ctx, e) {
 			emptyTable := plan.NewEmptyTableWithSchema(filter.Schema())
 			return emptyTable, transform.NewTree, nil
 		}
 
-		if isTrue(e) {
+		if isTrue(ctx, e) {
 			return filter.Child, transform.NewTree, nil
 		}
 
@@ -376,24 +376,24 @@ func simplifyFilters(ctx *sql.Context, a *Analyzer, node sql.Node, scope *plan.S
 	})
 }
 
-func isFalse(e sql.Expression) bool {
+func isFalse(ctx *sql.Context, e sql.Expression) bool {
 	lit, ok := e.(*expression.Literal)
 	if !ok || lit == nil || lit.Value() == nil {
 		return false
 	}
-	val, err := sql.ConvertToBool(sql.NewEmptyContext(), lit.Value())
+	val, err := sql.ConvertToBool(ctx, lit.Value())
 	if err != nil {
 		return false
 	}
 	return !val
 }
 
-func isTrue(e sql.Expression) bool {
+func isTrue(ctx *sql.Context, e sql.Expression) bool {
 	lit, ok := e.(*expression.Literal)
 	if !ok || lit == nil || lit.Value() == nil {
 		return false
 	}
-	val, err := sql.ConvertToBool(sql.NewEmptyContext(), lit.Value())
+	val, err := sql.ConvertToBool(ctx, lit.Value())
 	if err != nil {
 		return false
 	}