Reverting lsof changes on this branch; moved them to fulghum/lsof-output branch

Author: fulghum

server/listener.go

@@ -18,15 +18,11 @@ import (
 	"errors"
 	"fmt"
 	"net"
-	"os/exec"
 	"runtime"
-	"strings"
 	"sync"
 	"syscall"
 
 	"golang.org/x/sync/errgroup"
-
-	"github.com/sirupsen/logrus"
 )
 
 var UnixSocketInUseError = errors.New("bind address at given unix socket path is already in use")
@@ -59,35 +55,6 @@ type Listener struct {
 func NewListener(protocol, address string, unixSocketPath string) (*Listener, error) {
 	netl, err := newNetListener(protocol, address)
 	if err != nil {
-		// TODO: We're still seeing errors about address already in use, e.g:
-		//       https://github.com/dolthub/dolt/actions/runs/5395898150/jobs/9798898619?pr=6245#step:18:2240
-		// More examples:
-		//      https://github.com/dolthub/dolt/actions/runs/5395439523/jobs/9797921148#step:18:2249
-		//      https://github.com/dolthub/dolt/actions/runs/5404900318/jobs/9819723916?pr=6245#step:18:2216
-		//      https://github.com/dolthub/dolt/actions/runs/5406531989/jobs/9823511686?pr=6245#step:18:2216
-		if err != nil {
-			if strings.Contains(strings.ToLower(err.Error()), "address already in use") {
-				split := strings.Split(address, ":")
-				if len(split) == 2 {
-					port := split[1]
-					// if we're on unix, we should attempt to run lsof to see what is using the port and how
-					// and output that information in the error to the user:
-					//    lsof -i:<port>
-					if runtime.GOOS != "windows" {
-						cmd := exec.Command("lsof", fmt.Sprintf("-i:%s", port))
-						output, err := cmd.CombinedOutput()
-						if err != nil {
-							logrus.StandardLogger().Warnf("Unable to run lsof to detect what is using port %s: %s", port, err.Error())
-						} else {
-							logrus.StandardLogger().Warnf("lsof output: %s", string(output))
-						}
-					}
-				} else {
-					logrus.StandardLogger().Warnf("Unable to parse address into `host:port`: %s", address)
-				}
-			}
-		}
-
 		return nil, err
 	}