Skip to content

Commit 42f93ec

Browse files
committed
updated comments
1 parent b7ffa4a commit 42f93ec

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

sql/planbuilder/aggregates.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -197,9 +197,7 @@ func (b *Builder) buildAggregation(fromScope, projScope *scope, groupingCols []s
197197

198198
group := fromScope.groupBy
199199
outScope := group.outScope
200-
// select columns:
201-
// - aggs
202-
// - extra columns needed by having, order by, select
200+
// Select dependencies include aggregations and table columns needed for projections, having, and sort (order by)
203201
var selectDeps []sql.Expression
204202
var selectGfs []sql.Expression
205203
selectStr := make(map[string]bool)
@@ -252,7 +250,6 @@ func (b *Builder) buildAggregation(fromScope, projScope *scope, groupingCols []s
252250
return false
253251
}
254252

255-
// projection dependencies -> table cols needed above
256253
transform.InspectExpr(col.scalar, findSelectDeps)
257254
}
258255
for _, e := range fromScope.extraCols {

0 commit comments

Comments
 (0)