include other warnings

Author: James Cor

enginetest/queries/script_queries.go

@@ -1014,10 +1014,8 @@ var ScriptTests = []ScriptTest{
 					{"5.932887e7abc", uint64(5)},
 					{"a1a1", uint64(0)},
 				},
-				// TODO: Should be 19. Missing warnings for "Cast to unsigned converted negative integer to its positive
-				//  complement" (1105) https://github.com/dolthub/dolt/issues/9840
-				ExpectedWarningsCount: 16,
-				ExpectedWarning:       mysql.ERTruncatedWrongValue,
+				ExpectedWarningsCount: 19,
+				// Can't check multiple different warnings
 			},
 			{
 				Query: "select pk, cast(pk as decimal(12,3)) from test01",
@@ -1051,9 +1049,8 @@ var ScriptTests = []ScriptTest{
 				ExpectedWarningsCount: 0,
 			},
 
-			// TODO: these are not directly testing casting
-			// https://github.com/dolthub/dolt/issues/9739
 			{
+				// https://github.com/dolthub/dolt/issues/9739
 				Skip:    true,
 				Dialect: "mysql",
 				Query:   "select * from test01 where pk in (11)",

sql/expression/convert.go

@@ -413,13 +413,16 @@ func convertValue(ctx *sql.Context, val interface{}, castTo string, originType s
 			return nil, err
 		}
 		// TODO: if truncation error and out of range, then throw 2's complement warning
-		num, _, err := types.Uint64.Convert(ctx, value)
+		num, inRange, err := types.Uint64.Convert(ctx, value)
 		if err != nil {
-			num, _, err = types.Int64.Convert(ctx, value)
-			if err != nil {
-				return types.Uint64.Zero(), nil
-			}
-			return uint64(num.(int64)), nil
+			//num, inRange, err = types.Int64.Convert(ctx, value)
+			//if err != nil {
+			//	return types.Uint64.Zero(), nil
+			//}
+			//num = uint64(num.(int64))
+		}
+		if !inRange {
+			ctx.Warn(1105, "Cast to unsigned converted negative integer to its positive complement")
 		}
 		return num, nil
 	case ConvertToYear: