comments

Author: James Cor

sql/base_session.go

@@ -256,6 +256,7 @@ func (s *BaseSession) IncrementStatusVariable(ctx *Context, statVarName string,
 
 // NewStoredProcParam creates a new Stored Procedure Parameter in the Session
 func (s *BaseSession) NewStoredProcParam(name string, param *StoredProcParam) {
+	name = strings.ToLower(name)
 	if _, ok := s.storedProcParams[name]; ok {
 		return
 	}
@@ -264,6 +265,7 @@ func (s *BaseSession) NewStoredProcParam(name string, param *StoredProcParam) {
 
 // GetStoredProcParam retrieves the named stored procedure parameter, from the Session, returning nil if not found.
 func (s *BaseSession) GetStoredProcParam(name string) *StoredProcParam {
+	name = strings.ToLower(name)
 	if param, ok := s.storedProcParams[name]; ok {
 		return param
 	}

sql/planbuilder/proc.go

@@ -347,12 +347,15 @@ func (b *Builder) buildCall(inScope *scope, c *ast.Call) (outScope *scope) {
 
 	params := make([]sql.Expression, len(c.Params))
 	for i, param := range c.Params {
+		// While it is possible to detect a parameter count mismatch here and throw an error,
+		// there's some weirdness involving external procedures. The analyzer rule applyProceduresCall will
+		// catch this discrepancy.
 		if len(proc.Params) == len(c.Params) {
 			procParam := proc.Params[i]
 			rspp := &sql.StoredProcParam{Type: procParam.Type}
 			b.ctx.Session.NewStoredProcParam(procParam.Name, rspp)
 			if col, isCol := param.(*ast.ColName); isCol {
-				colName := col.Name.String() // TODO: to lower?
+				colName := col.Name.String()
 				if spp := b.ctx.Session.GetStoredProcParam(colName); spp != nil {
 					iv := &procedures.InterpreterVariable{
 						Type:  spp.Type,

sql/procedures/interpreter_operation.go

@@ -12,8 +12,7 @@ package procedures
 
 import ast "github.com/dolthub/vitess/go/vt/sqlparser"
 
-// OpCode states the operation to be performed. Most operations have a direct analogue to a Pl/pgSQL operation, however
-// some exist only in Doltgres (specific to our interpreter implementation).
+// OpCode is the internal representation queries run by Stored Procedures.
 type OpCode uint16
 
 const (

sql/session.go

@@ -92,13 +92,12 @@ type Session interface {
 	GetAllStatusVariables(ctx *Context) map[string]StatusVarValue
 	// IncrementStatusVariable increments the value of the status variable by the integer value
 	IncrementStatusVariable(ctx *Context, statVarName string, val int)
-
+	// NewStoredProcParam creates a new Stored Procedure Parameter in the Session.
 	NewStoredProcParam(name string, param *StoredProcParam)
-
+	// GetStoredProcParam finds and returns the Stored Procedure Parameter by the given name.
 	GetStoredProcParam(name string) *StoredProcParam
-
+	// SetStoredProcParam sets the Stored Procedure Parameter of the given name to the given val.
 	SetStoredProcParam(name string, val any) error
-
 	// GetCurrentDatabase gets the current database for this session
 	GetCurrentDatabase() string
 	// SetCurrentDatabase sets the current database for this session