Merge pull request #3126 from dolthub/angela/check_constraints

Added test for adding check constraint when modifying column

Author: angelamayxie

enginetest/queries/alter_table_queries.go

@@ -2273,6 +2273,20 @@ var ModifyColumnScripts = []ScriptTest{
 			},
 		},
 	},
+	{
+		// https://github.com/dolthub/dolt/issues/9591
+		Name: "Add check constraint when modifying column",
+		SetUpScript: []string{
+			"create table t(pk int primary key)",
+			"alter table t modify column pk int check(pk < 10)",
+		},
+		Assertions: []ScriptTestAssertion{
+			{
+				Query:       "insert into t values (20)",
+				ExpectedErr: sql.ErrCheckConstraintViolated,
+			},
+		},
+	},
 	{
 		Name:        "error cases",
 		SetUpScript: []string{},

go.mod

@@ -6,7 +6,7 @@ require (
 	github.com/dolthub/go-icu-regex v0.0.0-20250327004329-6799764f2dad
 	github.com/dolthub/jsonpath v0.0.2-0.20240227200619-19675ab05c71
 	github.com/dolthub/sqllogictest/go v0.0.0-20201107003712-816f3ae12d81
-	github.com/dolthub/vitess v0.0.0-20250611225316-90a5898bfe26
+	github.com/dolthub/vitess v0.0.0-20250729225143-5ab74d1f0182
 	github.com/go-kit/kit v0.10.0
 	github.com/go-sql-driver/mysql v1.7.2-0.20231213112541-0004702b931d
 	github.com/gocraft/dbr/v2 v2.7.2

go.sum

@@ -60,6 +60,8 @@ github.com/dolthub/sqllogictest/go v0.0.0-20201107003712-816f3ae12d81 h1:7/v8q9X
 github.com/dolthub/sqllogictest/go v0.0.0-20201107003712-816f3ae12d81/go.mod h1:siLfyv2c92W1eN/R4QqG/+RjjX5W2+gCTRjZxBjI3TY=
 github.com/dolthub/vitess v0.0.0-20250611225316-90a5898bfe26 h1:9Npf0JYVCrwe9edTfYD/pjIncCePNDiu4j50xLcV334=
 github.com/dolthub/vitess v0.0.0-20250611225316-90a5898bfe26/go.mod h1:1gQZs/byeHLMSul3Lvl3MzioMtOW1je79QYGyi2fd70=
+github.com/dolthub/vitess v0.0.0-20250729225143-5ab74d1f0182 h1:LrUmlwHlQLSu8OIL60APDGeUoPBoezeo8fTDRAe9EJg=
+github.com/dolthub/vitess v0.0.0-20250729225143-5ab74d1f0182/go.mod h1:1gQZs/byeHLMSul3Lvl3MzioMtOW1je79QYGyi2fd70=
 github.com/dustin/go-humanize v0.0.0-20171111073723-bb3d318650d4/go.mod h1:HtrtbFcZ19U5GC7JDqmcUSB87Iq5E25KnS6fMYU6eOk=
 github.com/eapache/go-resiliency v1.1.0/go.mod h1:kFI+JgMyC7bLPUVY133qvEBtVayf5mFgVsvEsIPBvNs=
 github.com/eapache/go-xerial-snappy v0.0.0-20180814174437-776d5712da21/go.mod h1:+020luEh2TKB4/GOp8oxxtq0Daoen/Cii55CzbTV6DU=

sql/analyzer/validate_create_table.go

@@ -458,7 +458,7 @@ func ValidateModifyColumn(ctx *sql.Context, initialSch sql.Schema, schema sql.Sc
 	// It cannot have been renamed in the same statement.
 	oldColName := mc.Column()
 	if !schema.Contains(oldColName, tableName) || !initialSch.Contains(oldColName, tableName) {
-		return nil, sql.ErrTableColumnNotFound.New(table, oldColName)
+		return nil, sql.ErrTableColumnNotFound.New(tableName, oldColName)
 	}
 
 	newCol := mc.NewColumn()