checkout group by ordinal range

Author: James Cor

enginetest/queries/script_queries.go

@@ -7782,6 +7782,32 @@ where
 			},
 		},
 	},
+	{
+		Name:    "group by ordinal tests",
+		Dialect: "mysql",
+		SetUpScript: []string{
+			"create table t (i int, j int);",
+		},
+		Assertions: []ScriptTestAssertion{
+			{
+				Query: "select 1 from t group by 'abc';",
+				ExpectedErrStr: "expected integer order by literal",
+			},
+			{
+				// TODO: this actually works in MySQL
+				Query: "select 1 from t group by -123;",
+				ExpectedErrStr: "expected positive integer order by literal",
+			},
+			{
+				Query: "select 1 from t group by 0;",
+				ExpectedErrStr: "expected positive integer order by literal",
+			},
+			{
+				Query: "select 1 from t group by 100;",
+				ExpectedErrStr: "column ordinal out of range: 100",
+			},
+		},
+	},
 }
 
 var SpatialScriptTests = []ScriptTest{

sql/planbuilder/aggregates.go

@@ -131,8 +131,12 @@ func (b *Builder) buildGroupingCols(fromScope, projScope *scope, groupby ast.Gro
 				b.handleErr(fmt.Errorf("expected integer order by literal"))
 			}
 			if intIdx < 1 {
+				// TODO: this actually works in MySQL
 				b.handleErr(fmt.Errorf("expected positive integer order by literal"))
 			}
+			if int(intIdx) > len(selects) {
+				b.handleErr(fmt.Errorf("column ordinal out of range: %d", intIdx))
+			}
 			col = projScope.cols[intIdx-1]
 		default:
 			expr := b.buildScalar(fromScope, e)