comments

Author: James Cor

sql/analyzer/fix_exec_indexes.go

@@ -454,6 +454,7 @@ func (s *idxScope) visitSelf(n sql.Node) error {
 						break
 					}
 				}
+				// unable to find column, use copy with OnDupValuesPrefix or fallback
 				if newC == nil {
 					if len(destSch) != len(srcSch) {
 						newC = c.Copy()

sql/planbuilder/dml.go

@@ -120,6 +120,7 @@ func (b *Builder) buildInsert(inScope *scope, i *ast.Insert) (outScope *scope) {
 		combinedScope.insertColumnAliases = inScope.insertColumnAliases
 		for i, c := range destScope.cols {
 			combinedScope.newColumn(c)
+			// if the srcScope is empty, it is a values statement
 			if len(srcScope.cols) == 0 {
 				// The to-be-inserted values can be referenced via the provided alias.
 				c.table = combinedScope.insertTableAlias