Skip to content

Commit 580ca59

Browse files
elianddbclaude
andcommitted
Un-skip auto-increment overflow tests from PR #3100
Removed Skip: true from tests that verify auto-increment behavior at maximum values. Our fix now allows these tests to pass: - Insert max values (127 for TINYINT, 32767 for SMALLINT, etc.) - Verify SHOW CREATE TABLE shows correct AUTO_INCREMENT values - Removed redundant auto_increment_overflow_test.go file Tests now properly validate that AUTO_INCREMENT values don't exceed type limits and display correctly in SHOW CREATE TABLE output. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 6bd2573 commit 580ca59

File tree

2 files changed

+1
-123
lines changed

2 files changed

+1
-123
lines changed

enginetest/queries/auto_increment_overflow_test.go

Lines changed: 0 additions & 114 deletions
This file was deleted.

enginetest/queries/script_queries.go

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10486,7 +10486,6 @@ where
1048610486
ExpectedErr: sql.ErrValueOutOfRange,
1048710487
},
1048810488
{
10489-
Skip: true,
1049010489
Query: "insert into tinyint_tbl values (127)",
1049110490
Expected: []sql.Row{
1049210491
{types.OkResult{
@@ -10496,7 +10495,6 @@ where
1049610495
},
1049710496
},
1049810497
{
10499-
Skip: true,
1050010498
Query: "show create table tinyint_tbl;",
1050110499
Expected: []sql.Row{
1050210500
{"tinyint_tbl", "CREATE TABLE `tinyint_tbl` (\n" +
@@ -10512,7 +10510,6 @@ where
1051210510
ExpectedErr: sql.ErrValueOutOfRange,
1051310511
},
1051410512
{
10515-
Skip: true,
1051610513
Query: "insert into smallint_tbl values (32767);",
1051710514
Expected: []sql.Row{
1051810515
{types.OkResult{
@@ -10522,13 +10519,12 @@ where
1052210519
},
1052310520
},
1052410521
{
10525-
Skip: true,
1052610522
Query: "show create table smallint_tbl;",
1052710523
Expected: []sql.Row{
1052810524
{"smallint_tbl", "CREATE TABLE `smallint_tbl` (\n" +
1052910525
" `i` smallint NOT NULL AUTO_INCREMENT,\n" +
1053010526
" PRIMARY KEY (`i`)\n" +
10531-
") ENGINE=InnoDB AUTO_INCREMENT=36727 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_bin"},
10527+
") ENGINE=InnoDB AUTO_INCREMENT=32767 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_bin"},
1053210528
},
1053310529
},
1053410530

@@ -10564,7 +10560,6 @@ where
1056410560
ExpectedErr: sql.ErrValueOutOfRange,
1056510561
},
1056610562
{
10567-
Skip: true,
1056810563
Query: "insert into int_tbl values (2147483647)",
1056910564
Expected: []sql.Row{
1057010565
{types.OkResult{
@@ -10574,7 +10569,6 @@ where
1057410569
},
1057510570
},
1057610571
{
10577-
Skip: true,
1057810572
Query: "show create table int_tbl;",
1057910573
Expected: []sql.Row{
1058010574
{"int_tbl", "CREATE TABLE `int_tbl` (\n" +
@@ -10590,7 +10584,6 @@ where
1059010584
ExpectedErr: sql.ErrValueOutOfRange,
1059110585
},
1059210586
{
10593-
Skip: true,
1059410587
Query: "insert into bigint_tbl values (9223372036854775807);",
1059510588
Expected: []sql.Row{
1059610589
{types.OkResult{
@@ -10600,7 +10593,6 @@ where
1060010593
},
1060110594
},
1060210595
{
10603-
Skip: true,
1060410596
Query: "show create table bigint_tbl;",
1060510597
Expected: []sql.Row{
1060610598
{"bigint_tbl", "CREATE TABLE `bigint_tbl` (\n" +

0 commit comments

Comments
 (0)