PR feedback: return validation error as early as possible

fulghum · fulghum · commit 58352f2c01ec · 2025-04-14T13:28:23.000-07:00
diff --git a/sql/rowexec/ddl_iters.go b/sql/rowexec/ddl_iters.go
@@ -1876,8 +1876,12 @@ func (b *BaseBuilder) executeDropCheck(ctx *sql.Context, n *plan.DropCheck) erro
 		}
 	}
 
-	if !exists && n.IfExists {
-		return nil
+	if !exists {
+		if n.IfExists {
+			return nil
+		} else {
+			return fmt.Errorf("check '%s' was not found on the table", n.Name)
+		}
 	}
 
 	return chAlterable.DropCheck(ctx, n.Name)

Original file line number	Diff line number	Diff line change
`@@ -1876,8 +1876,12 @@ func (b BaseBuilder) executeDropCheck(ctx sql.Context, n *plan.DropCheck) erro`
`1876`	`1876`	`}`
`1877`	`1877`	`}`
`1878`	`1878`
`1879`		`- if !exists && n.IfExists {`
`1880`		`- return nil`
	`1879`	`+ if !exists {`
	`1880`	`+ if n.IfExists {`
	`1881`	`+ return nil`
	`1882`	`+ } else {`
	`1883`	`+ return fmt.Errorf("check '%s' was not found on the table", n.Name)`
	`1884`	`+ }`
`1881`	`1885`	`}`
`1882`	`1886`
`1883`	`1887`	`return chAlterable.DropCheck(ctx, n.Name)`