tmp patch

Author: James Cor

sql/expression/convert.go

@@ -366,7 +366,8 @@ func convertValue(ctx *sql.Context, val interface{}, castTo string, originType s
 		}
 		return d, nil
 	case ConvertToDouble, ConvertToReal:
-		value, err := prepareForNumericContext(val, originType, false)
+		//value, err := prepareForNumericContext(val, originType, false)
+		value, err := types.ConvertOrTruncate(ctx, val, originType)
 		if err != nil {
 			return nil, err
 		}

sql/types/conversion.go

@@ -766,8 +766,13 @@ func TypeAwareConversion(ctx *sql.Context, val interface{}, originalType sql.Typ
 // ConvertOrTruncate converts the value |i| to type |t| and returns the converted value; if the value does not convert
 // cleanly and the type is automatically coerced (i.e. string and numeric types), then a warning is logged and the
 // value is truncated to the Zero value for type |t|. If the value does not convert and the type is not automatically
-// coerced, then an error is returned.
+// coerced, then return an error.
 func ConvertOrTruncate(ctx *sql.Context, i interface{}, t sql.Type) (interface{}, error) {
+	// Do nothing if type is no provided.
+	if t == nil {
+		return i, nil
+	}
+
 	converted, _, err := t.Convert(ctx, i)
 	if err == nil {
 		return converted, nil

sql/types/number.go

@@ -1537,6 +1537,7 @@ func convertToFloat64(t NumberTypeImpl_, v interface{}) (float64, error) {
 		}
 		return float64(i), nil
 	case string:
+		// TODO: just trimStringToPrefix here
 		v = strings.Trim(v, NumericCutSet)
 		i, err := strconv.ParseFloat(v, 64)
 		if err != nil {