Skip to content

Commit 5cbc653

Browse files
committed
unwrap ParenExpr in group by
1 parent 797f25f commit 5cbc653

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

sql/planbuilder/orderby.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,11 @@ func (b *Builder) analyzeOrderBy(fromScope, projScope *scope, order ast.OrderBy)
4646
case ast.DescScr:
4747
descending = true
4848
}
49-
50-
switch e := o.Expr.(type) {
49+
expr := o.Expr
50+
if parensExpr, ok := expr.(*ast.ParenExpr); ok {
51+
expr = parensExpr.Expr
52+
}
53+
switch e := expr.(type) {
5154
case *ast.ColName:
5255
// check for projection alias first
5356
dbName := strings.ToLower(e.Qualifier.DbQualifier.String())
@@ -147,7 +150,7 @@ func (b *Builder) analyzeOrderBy(fromScope, projScope *scope, order ast.OrderBy)
147150
// has to have been ref'd already
148151
id, ok := fromScope.getExpr(e.String(), true)
149152
if !ok {
150-
err := fmt.Errorf("faild to ref aggregate expression: %s", e.String())
153+
err := fmt.Errorf("failed to ref aggregate expression: %s", e.String())
151154
b.handleErr(err)
152155
}
153156
return expression.NewGetField(int(id), e.Type(), e.String(), e.IsNullable()), transform.NewTree, nil

0 commit comments

Comments
 (0)