Skip to content

Commit 60e129c

Browse files
committed
sql/memory.go: Add a sanity check to enginetests to assert caches are cleaned up.
1 parent 27931ae commit 60e129c

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

enginetest/enginetests.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3630,6 +3630,8 @@ func TestQueryWithContext(t *testing.T, ctx *sql.Context, e *sqle.Engine, q stri
36303630
require.NoError(err, "Unexpected error for query %s", q)
36313631

36323632
checkResults(t, require, expected, expectedCols, sch, rows, q)
3633+
3634+
require.Equal(0, ctx.Memory.NumCaches())
36333635
}
36343636

36353637
func checkResults(t *testing.T, require *require.Assertions, expected []sql.Row, expectedCols []*sql.Column, sch sql.Schema, rows []sql.Row, q string) {

sql/memory.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,3 +216,9 @@ func (m *MemoryManager) Free() {
216216
}
217217
}
218218
}
219+
220+
func (m *MemoryManager) NumCaches() int {
221+
m.mu.RLock()
222+
defer m.mu.RUnlock()
223+
return len(m.caches)
224+
}

0 commit comments

Comments
 (0)