rm push on anti and semi join

Author: elianddb

enginetest/join_planning_tests.go

@@ -51,6 +51,30 @@ type joinPlanScript struct {
 }
 
 var JoinPlanningTests = []joinPlanScript{
+	{
+		// https://github.com/dolthub/dolt/issues/9977
+		name: "filters with anti and semi joins",
+		setup: []string{
+			"CREATE table xy (x int, y int, primary key(x,y));",
+			"insert into xy values (1,0), (2,1), (0,2), (3,3);",
+		},
+		tests: []JoinPlanTest{
+			{
+				// When NOT IN and IN are combined, the IN filter should not be pushed into the Anti join
+				q:     "select * from xy where x > 0 and x not in (select 999) and x in (select 1 union select 2) order by x",
+				types: []plan.JoinType{plan.JoinTypeLeftOuter},
+				exp: []sql.Row{
+					{1, 0},
+					{2, 1},
+				},
+			},
+			{
+				q:     "select * from xy where x > 0 and x not in (select 999) and x in (select 888 union select 777)",
+				types: []plan.JoinType{plan.JoinTypeLeftOuter},
+				exp:   []sql.Row{},
+			},
+		},
+	},
 	{
 		name: "filter pushdown through join uppercase name",
 		setup: []string{

sql/analyzer/pushdown.go

@@ -326,7 +326,7 @@ func updateFilterNode(ctx *sql.Context, a *Analyzer, node *plan.Filter, filters
 	}
 
 	// push filters into joinChild
-	if joinChild, ok := node.Child.(*plan.JoinNode); ok && !joinChild.Op.IsOuter() {
+	if joinChild, ok := node.Child.(*plan.JoinNode); ok && !joinChild.Op.IsOuter() && !joinChild.Op.IsSemi() && !joinChild.Op.IsAnti() {
 		a.Log("pushing filters into join node")
 		if joinChild.Op.IsCross() {
 			return plan.NewInnerJoin(joinChild.Left(), joinChild.Right(), expression.JoinAnd(unhandled...))