[no-release-notes] fix bug in memory session data management (#2353)

Author: max-hoffman

enginetest/queries/script_queries.go

@@ -121,6 +121,30 @@ var ScriptTests = []ScriptTest{
 			},
 		},
 	},
+	{
+		Name: "GMS issue 2349",
+		SetUpScript: []string{
+			"CREATE TABLE table1 (id int NOT NULL AUTO_INCREMENT primary key, name text)",
+			`
+CREATE TABLE table2 (
+	id int NOT NULL AUTO_INCREMENT,
+	name text,
+	fk int,
+	PRIMARY KEY (id),
+	CONSTRAINT myConstraint FOREIGN KEY (fk) REFERENCES table1 (id)
+)`,
+		},
+		Assertions: []ScriptTestAssertion{
+			{
+				Query:    "INSERT INTO table1 (name) VALUES ('tbl1 row 1');",
+				Expected: []sql.Row{{types.OkResult{RowsAffected: 1, InsertID: 1}}},
+			},
+			{
+				Query:    "INSERT INTO table1 (name) VALUES ('tbl1 row 2');",
+				Expected: []sql.Row{{types.OkResult{RowsAffected: 1, InsertID: 2}}},
+			},
+		},
+	},
 	{
 		Name: "missing indexes",
 		SetUpScript: []string{

memory/session.go

@@ -118,6 +118,7 @@ func (s *Session) dropTable(d *TableData) {
 // Because we don't support concurrency, we store table data changes in the session, rather than the transaction itself.
 func (s *Session) StartTransaction(ctx *sql.Context, tCharacteristic sql.TransactionCharacteristic) (sql.Transaction, error) {
 	s.tables = make(map[tableKey]*TableData)
+	s.editAccumulators = make(map[tableKey]tableEditAccumulator)
 	return &Transaction{tCharacteristic == sql.ReadOnly}, nil
 }